-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency #3653
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @lorenzo-rovigatti, @junghans it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
@lorenzo-rovigatti @junghans make sure to accept the invitation to the reviewers group and to have a look at the reviewer guidelines linked to at the top of this review page. The review process will happen in this issue page, so questions to the author or to me can be added as comments here. As this is the first JOSS review for one of you (unless I missed something), do not hesitate to ask questions if you have doubts about the procedure. You can also take a look at earlier reviews to get an idea of how the reviews proceed https://github.com/openjournals/joss-reviews/issues?q=is%3Aissue+label%3Aaccepted+ |
@antoinediez please check the missing dois |
@whedon generate pdf |
@whedon check references |
|
@whedon generate pdf |
👋 @lorenzo-rovigatti, please update us on how your review is going (this is an automated reminder). |
👋 @junghans, please update us on how your review is going (this is an automated reminder). |
Done. |
Thanks @junghans for the review! |
@lorenzo-rovigatti I see that you have checked a number of items already. Do you need extra information to proceed? You can contact the authors here or, if it makes sense, open an issue at the project directly. |
PS: @lorenzo-rovigatti check the issue there as well antoinediez/Sisyphe#2 |
Yes, I started working on the review but then I had to stop for a few days. I'll get back to it this week. Sorry for any delay this may cause! |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2619 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2619, then you can now move forward with accepting the submission by compiling again with the flag
|
Thank you @antoinediez for the update. All is ok with the paper, one of the editors-in-chief will pick up the submission. Thanks @junghans and @lorenzo-rovigatti for the review! |
@antoinediez - I've suggested some minor changes to the paper in antoinediez/Sisyphe#5 - please merge this, or let me know what you disagree with, then we can proceed to acceptance and publication. |
Hi @danielskatz ! |
@whedon recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2620 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2620, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @antoinediez (Antoine Diez)!! And thanks to @lorenzo-rovigatti and @junghans for reviewing, and to @pdebuyl for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @antoinediez (Antoine Diez)
Repository: https://github.com/antoinediez/Sisyphe
Version: v1.0
Editor: @pdebuyl
Reviewer: @lorenzo-rovigatti, @junghans
Archive: 10.5281/zenodo.5532924
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lorenzo-rovigatti & @junghans, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @pdebuyl know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @lorenzo-rovigatti
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @junghans
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: