Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SiSyPHE: A Python package for the Simulation of Systems of Particles with High Efficiency #3425

Closed
whedon opened this issue Jun 28, 2021 · 27 comments

Comments

@whedon
Copy link

whedon commented Jun 28, 2021

Submitting author: @antoinediez (Antoine Diez)
Repository: https://github.com/antoinediez/Sisyphe
Version: v0.1.5
Editor: @pdebuyl
Reviewers: @lorenzo-rovigatti, @junghans
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aef04ea8a4e78bcf320cb93e747c8bae"><img src="https://joss.theoj.org/papers/aef04ea8a4e78bcf320cb93e747c8bae/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aef04ea8a4e78bcf320cb93e747c8bae/status.svg)](https://joss.theoj.org/papers/aef04ea8a4e78bcf320cb93e747c8bae)

Author instructions

Thanks for submitting your paper to JOSS @antoinediez. Currently, there isn't an JOSS editor assigned to your paper.

@antoinediez if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 28, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 28, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.21 s (566.6 files/s, 228162.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            27           3451             81          10525
JavaScript                      14           2404           2467           9203
Python                          21           1206           2156           3274
SVG                              2              0              0           2672
CSS                              9            200             57           1154
TeX                              1             55              4            570
reStructuredText                28           2577           2288            470
Markdown                         2             46              0            129
Jupyter Notebook                10              0           1959             88
DOS Batch                        1              8              1             26
make                             1              5              7             11
YAML                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           117           9956           9027          28131
-------------------------------------------------------------------------------


Statistical information for the repository 'fb6fe8b3a67292372981de6d' was
gathered on 2021/06/28.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Antoine Diez                    32         40852          17140          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Antoine Diez              23712           58.0          0.1               17.24

@whedon whedon added the Python label Jun 28, 2021
@whedon
Copy link
Author

whedon commented Jun 28, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Jun 28, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/0021-9991(87)90140-9 is OK
- 10.1103/PhysRevLett.75.1226 is OK
- 10.1142/S0218202508003005 is OK
- 10.1007/s11537-007-0647-x is OK
- 10.1007/978-0-8176-4946-3_12 is OK
- 10.1007/s00205-014-0800-7 is OK
- 10.1142/S0218202516500330 is OK
- 10.1142/S0218202519500374 is OK
- 10.1142/S021820252040014X is OK
- 10.1002/pamm.201800291 is OK
- 10.1142/S0218202517400061 is OK
- 10.1137/18M1192184 is OK
- 10.1073/pnas.1806579115 is OK
- 10.1016/j.physrep.2012.03.004 is OK
- 10.1214/15-AIHP701 is OK
- 10.1109/ICNN.1995.488968 is OK
- 10.1103/PhysRevE.77.046113 is OK
- 10.1007/s10955-014-1119-3 is OK
- 10.1103/PhysRevE.58.4828 is OK
- 10.1073/pnas.1202032109 is OK
- 10.1103/PhysRevE.92.032722 is OK
- 10.1007/978-1-4757-3437-9 is OK
- 10.1109/78.984773 is OK
- 10.3182/20090706-3-FR-2004.00129 is OK
- 10.1198/106186004X12803 is OK

MISSING DOIs

- 10.1007/bfb0093177 may be a valid DOI for title: Asymptotic Behaviour of some interacting particle systems; McKean-Vlasov and Boltzmann models
- 10.4310/cms.2009.v7.n2.a9 may be a valid DOI for title: Emergence of time-asymptotic flocking in a stochastic Cucker-Smale system
- 10.1016/j.jfa.2014.02.030 may be a valid DOI for title: On Kac’s chaos and related problems
- 10.1080/07362994.2018.1486202 may be a valid DOI for title: McKean–Vlasov limit for interacting systems with simultaneous jumps
- 10.1142/9789813272880_0206 may be a valid DOI for title: Mathematical models of collective dynamics and self-organization
- 10.1007/978-3-030-15096-9_2 may be a valid DOI for title: Alignment of Self-propelled Rigid Bodies: From Particle Systems to Macroscopic Equations
- 10.1214/aoap/1028903535 may be a valid DOI for title: Measure-valued processes and interacting particle systems. Application to nonlinear filtering problems
- 10.1016/j.jcp.2019.108877 may be a valid DOI for title: Random batch methods (RBM) for interacting particle systems

INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Jun 28, 2021

👋 @antoinediez - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

If you want to fix the DOIs (noting that whedon's suggestions are not always right), you can, then use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references.

@whedon generate pdf
@whedon check references

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 28, 2021
@antoinediez
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 28, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@antoinediez
Copy link

@whedon check references

1 similar comment
@antoinediez
Copy link

@whedon check references

@kthyng
Copy link

kthyng commented Jul 15, 2021

Hi @pdebuyl this was the other submission I mentioned that looked like a good fit for you. Can you take this on when you are back in the office in August?

@kthyng
Copy link

kthyng commented Jul 15, 2021

@whedon invite @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Jul 15, 2021

@pdebuyl has been invited to edit this submission.

@pdebuyl
Copy link

pdebuyl commented Jul 15, 2021

Hi @kthyng I'd be happy to edit this!

@pdebuyl
Copy link

pdebuyl commented Jul 15, 2021

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jul 15, 2021

OK, the editor is @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Jul 15, 2021

@antoinediez I'll start looking for reviewers in august, sorry for the delay.

@pdebuyl
Copy link

pdebuyl commented Aug 17, 2021

@whedon assign @lorenzo-rovigatti as reviewer

@whedon whedon assigned pdebuyl and unassigned pdebuyl Aug 17, 2021
@whedon
Copy link
Author

whedon commented Aug 17, 2021

OK, @lorenzo-rovigatti is now a reviewer

@pdebuyl pdebuyl removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 17, 2021
@antoinediez
Copy link

Hi @pdebuyl and @lorenzo-rovigatti ! 👋

Sorry for the late answer and thank you very much for having accepted to edit and review this work.

@pdebuyl if you are looking for a second reviewer, based on the list provided and on the keywords, may I suggest (without any specific order):

  • vyasr
  • schroedtert
  • dalg24
  • csadorf
  • Christovis
  • junghans
  • rusu24edward

@pdebuyl
Copy link

pdebuyl commented Aug 23, 2021

Thanks @antoinediez for the suggestsions. I was waiting for another reviewer's reply but will contact other candidates anyway.

@pdebuyl
Copy link

pdebuyl commented Aug 23, 2021

@junghans would you review the article "SiSyPHE: A Python package for the Simulation of Systems of Particles with High Efficiency" for the Journal of Open Source Software ?

@junghans
Copy link

@pdebuyl I am happy to.

@pdebuyl
Copy link

pdebuyl commented Aug 24, 2021

Thanks a lot @junghans !

@pdebuyl
Copy link

pdebuyl commented Aug 24, 2021

@whedon add @junghans as reviewer

@whedon
Copy link
Author

whedon commented Aug 24, 2021

OK, @junghans is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Aug 24, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 24, 2021

OK, I've started the review over in #3653.

@whedon whedon closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants