Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: fishRman: A Shiny R Dashboard improving Global Fishing Watch data availability #3333

Closed
whedon opened this issue Jun 5, 2021 · 29 comments
Assignees
Labels
CSS pre-review R waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@whedon
Copy link

whedon commented Jun 5, 2021

Submitting author: @Shyentist (Pasquale Buonomo)
Repository: https://github.com/Shyentist/fish-r-man
Version: v1.0.0
Editor: @KristinaRiemer
Reviewers: @jules32, @HeatherWelch
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9895e0e14fbd2be0622022dbbe15fe10"><img src="https://joss.theoj.org/papers/9895e0e14fbd2be0622022dbbe15fe10/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9895e0e14fbd2be0622022dbbe15fe10/status.svg)](https://joss.theoj.org/papers/9895e0e14fbd2be0622022dbbe15fe10)

Author instructions

Thanks for submitting your paper to JOSS @Shyentist. Currently, there isn't an JOSS editor assigned to your paper.

@Shyentist if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 5, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 5, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (487.1 files/s, 61518.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            19             27              0           1923
R                               11            265             63           1758
CSS                              1             85              0            147
Markdown                         4             37              0            115
-------------------------------------------------------------------------------
SUM:                            35            414             63           3943
-------------------------------------------------------------------------------


Statistical information for the repository '4927541a908dcf250f369f54' was
gathered on 2021/06/05.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Jun 5, 2021

PDF failed to compile for issue #3333 with the following error:

 Can't find any papers to compile :-(

@Shyentist
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 5, 2021

PDF failed to compile for issue #3333 with the following error:

 /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:147:in `check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError)
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:89:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

@Kevin-Mattheus-Moerman
Copy link
Member

@Shyentist it looks like the YAML content at the top of the paper is not as expected/standard. In particular the affiliation field is missing. Can you add it? I believe you can also leave it empty.

@Shyentist
Copy link

@Kevin-Mattheus-Moerman thank you, I added "Independent researcher" as affiliation. Would that be okay?

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 5, 2021

PDF failed to compile for issue #3333 with the following error:

 /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in `parse': (9a92dbd0b52e56f728be8eb9/paper/paper.md): found a tab character that violate intendation while scanning a plain scalar at line 14 column 12 (Psych::SyntaxError)
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in `parse_stream'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:390:in `parse'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:277:in `load'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:578:in `block in load_file'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in `open'
	from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in `load_file'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:127:in `load_yaml'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:87:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

@Kevin-Mattheus-Moerman
Copy link
Member

@marcosvital this looks like something you could handle. However, you appear to be at capacity in terms of the number of papers you are already handling. I will label this submission as waitlisted until you, or another suitable editor, becomes available.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 5, 2021
@Shyentist
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 5, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @KristinaRiemer - Would you be willing to edit this submission?

@danielskatz
Copy link

@whedon invite @KristinaRiemer as editor

@whedon
Copy link
Author

whedon commented Jun 16, 2021

@KristinaRiemer has been invited to edit this submission.

@KristinaRiemer
Copy link

I can edit this submission.

@KristinaRiemer
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jun 21, 2021

OK, the editor is @KristinaRiemer

@KristinaRiemer
Copy link

@saskiaotto @jules32 @HeatherWelch would you be able and willing to be a reviewer for this JOSS software submission?

If you're not familiar with JOSS, these reviews happen openly on GitHub and are guided by this checklist. There's some more information on this process here. There's a link to the GitHub repo for the submission in the first comment on this issue.

@jules32
Copy link

jules32 commented Jul 6, 2021

Hi @KristinaRiemer – yes I would be able to review by the end of the month, would that timeline work for you?

@KristinaRiemer
Copy link

Hi @jules32, that would be great, thank you so much! I'll assign you a reviewer, the review won't start until I have found a second reviewer.

@saskiaotto @HeatherWelch would either of you be able to review this submission? Let me know if that's possible!

@KristinaRiemer
Copy link

@whedon assign @jules32 as reviewer

@whedon
Copy link
Author

whedon commented Jul 7, 2021

OK, @jules32 is now a reviewer

@HeatherWelch
Copy link

HeatherWelch commented Jul 9, 2021 via email

@KristinaRiemer
Copy link

@whedon add @HeatherWelch as reviewer

@whedon
Copy link
Author

whedon commented Jul 9, 2021

OK, @HeatherWelch is now a reviewer

@KristinaRiemer
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 9, 2021

OK, I've started the review over in #3467.

@whedon whedon closed this as completed Jul 9, 2021
@KristinaRiemer
Copy link

Great, thanks so much @HeatherWelch!

@jules32 and @HeatherWelch, the review will take place in the GitHub issue linked in the previous comment. There is a checklist to help guide your review over there. You can provide comments to the submission author by creating new issues in the software repository, or by posting overall comments in the review issue. Also free free to let me know how I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS pre-review R waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

7 participants