Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: nnde: A Python package for solving differential equations using neural networks #3309

Closed
whedon opened this issue May 23, 2021 · 46 comments
Closed

[PRE REVIEW]: nnde: A Python package for solving differential equations using neural networks #3309

whedon opened this issue May 23, 2021 · 46 comments
Assignees
@diehlpk @hayesall @taless474
Labels
Makefile pre-review Python

Comments

@whedon
Copy link

whedon commented May 23, 2021 •
edited
Loading

Submitting author: @elwinter (Eric Winter)
Repository: https://github.com/elwinter/nnde
Version: 0.0.7
Editor: @diehlpk
Reviewers: @taless474, @hayesall
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb"><img src="https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb/status.svg)](https://joss.theoj.org/papers/928f78def0b6f73aecf73326fd390aeb)

Author instructions

Thanks for submitting your paper to JOSS @elwinter. Currently, there isn't an JOSS editor assigned to your paper.

@elwinter if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 23, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2021 

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.11 s (813.9 files/s, 83836.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          86           2297           2105           4778
Markdown                         2             27              0             47
make                             1              3              0              8
JSON                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                            90           2327           2105           4839
-------------------------------------------------------------------------------


Statistical information for the repository 'd69281d3a87121bdbe2d8c8b' was
gathered on 2021/05/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Eric Winter                    191         18127           8947          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Eric Winter                9180           50.6          5.8               13.41

@whedon
Copy link
Author

whedon commented May 23, 2021

PDF failed to compile for issue #3309 with the following error:

 pandoc: paper.bib: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@arfon
Copy link
Member

arfon commented May 23, 2021

👋 @elwinter – thanks for your submission to JOSS. It looks like you're missing the BibTeX file to go with the paper.md file here?

@elwinter
Copy link

elwinter commented May 23, 2021 via email

@arfon
Copy link
Member

arfon commented May 24, 2021

I hope all is well with you Arfon. I left ST in December for APL.

👋 all good here thanks! Congrats on the new role, I hope APL is treating you well!

@elwinter
Copy link

elwinter commented May 24, 2021 via email

@arfon
Copy link
Member

arfon commented May 24, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 24, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented May 29, 2021

@elwinter – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 29, 2021
@danielskatz
Copy link

👋 @diehlpk - would you be able to edit this submission?

@danielskatz
Copy link

@whedon invite @diehlpk as editor

@whedon
Copy link
Author

whedon commented Jun 15, 2021

@diehlpk has been invited to edit this submission.

@diehlpk
Copy link
Member

diehlpk commented Jun 15, 2021

@danielskatz Sure, I can take the submission.

@diehlpk
Copy link
Member

diehlpk commented Jun 15, 2021

@whedon assign @diehlpk as editor

@whedon
Copy link
Author

whedon commented Jun 15, 2021

OK, the editor is @diehlpk

@diehlpk diehlpk removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 15, 2021
@diehlpk
Copy link
Member

diehlpk commented Jun 15, 2021

@elwinter Can you please recommend some reviewers?

@elwinter
Copy link

elwinter commented Jun 15, 2021 via email

@diehlpk
Copy link
Member

diehlpk commented Jun 15, 2021

Hey @taless474 would you be interested to review this paper?

@taless474
Copy link

Sure, I will do that.

@diehlpk
Copy link
Member

diehlpk commented Jun 16, 2021

@whedon assign @taless474 as reviewer

@whedon
Copy link
Author

whedon commented Jun 16, 2021

OK, @taless474 is now a reviewer

@diehlpk
Copy link
Member

diehlpk commented Jun 16, 2021

Hey @rougier @betatim @pragyansmita @stsievert @road2stat @nilesh-patil would you be interested in reviewing this paper?

@stsievert
Copy link

Sorry, I don't have the bandwidth right now. After a brief glance, I would encourage the author to look carefully at the JOSS review criteria, especially the documentation section.

@elwinter
Copy link

elwinter commented Jun 16, 2021 via email

@diehlpk
Copy link
Member

diehlpk commented Jun 18, 2021

Hey, @AvianaGlobal @a-r-j @chekoduadarsh @diegoonna @coljac @davismcc would you be interested in reviewing this paper?

@diehlpk
Copy link
Member

diehlpk commented Jun 21, 2021

Hey @johntfoster would you be interested to review this paper?

@a-r-j
Copy link

a-r-j commented Jun 21, 2021

Hi @diehlpk, afraid I don't have the bandwidth right now either. Apologies!

@coljac
Copy link

coljac commented Jun 21, 2021

@diehlpk : Apologies, I usually try and squeeze in reviews when asked, but I have to decline this one.

@davismcc
Copy link

davismcc commented Jun 22, 2021 via email

@diehlpk
Copy link
Member

diehlpk commented Jun 24, 2021

@elwinter Do you have some reviewers in mind?

@diehlpk
Copy link
Member

diehlpk commented Jun 28, 2021 •
edited
Loading

Hey @tianxzhu @paragkulkarni11 @GalenStocking @nhejazi @dvysardana @glemaitre @scivision @rasbt would you be interested to review this paper?

@nhejazi
Copy link

nhejazi commented Jun 28, 2021

Thank you for considering me, but I am unable to provide a timely review at present.

@diehlpk
Copy link
Member

diehlpk commented Jul 6, 2021 •
edited
Loading

@elwinter Do you have some reviewers in mind?

@elwinter Do you have reviewers in mind? I would appreciate getting some names from you?

@diehlpk
Copy link
Member

diehlpk commented Jul 7, 2021

Hey @Smith42 @hayesall @anki-xyz @vasudev-sharma @88d52bdba0366127fffca9dfa93895 @magedhelmy1 would you be interested in reviewing this paper?

@elwinter
Copy link

elwinter commented Jul 7, 2021 via email

@diehlpk
Copy link
Member

diehlpk commented Jul 8, 2021

Hi Patrick. Sorry for the delayed reply. I had suggested one reviewer from the JOSS list when I submitted the paper, but I see in my email archive that you are not having much luck getting a reviewer from your usual team. The only person on your team I could suggest is Arfon, but we know each other from working together at STScI, so that would not be appropriate, unless the reviews are blind. But even then, there’s a good chance he’d know it’s me, so Arfon should not be a candidate. Should I go through the list of your reviewers from the web site again? Or do you need to find an external reviewer at this point? Take care Eric From: Patrick Diehl @.> Sent: Tuesday, July 6, 2021 5:07 PM To: openjournals/joss-reviews @.> Cc: Eric Winter @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: nnde: A Python package for solving differential equations using neural networks (#3309) @elwinter https://github.com/elwinter Do you have some reviewers in mind? @elwinter https://github.com/elwinter Do you have reviewers in mind? I would appreciated to get some names from you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3309 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSFWC6MKC7O57QUGMQHQ3TTWNV6PANCNFSM45LZJJXA . https://github.com/notifications/beacon/ABSFWC26FRGIPEAQH5JPRGLTWNV6PA5CNFSM45LZJJXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGQUK7SA.gif

Yeah, I think I asked some of the reviewers in the JOSS list. I can wait for some time and ask the next round. I was thinking you have can recommend some external ones.m since you work on this topic.

@elwinter
Copy link

elwinter commented Jul 9, 2021 via email

@hayesall
Copy link

hayesall commented Jul 9, 2021

Hey @diehlpk I can help review.

@diehlpk
Copy link
Member

diehlpk commented Jul 9, 2021

@whedon add @hayesall as reviewer

1 similar comment
@diehlpk
Copy link
Member

diehlpk commented Jul 9, 2021

@whedon add @hayesall as reviewer

@whedon whedon assigned diehlpk, hayesall and taless474 and unassigned diehlpk and taless474 Jul 9, 2021
@whedon
Copy link
Author

whedon commented Jul 9, 2021

OK, @hayesall is now a reviewer

@diehlpk
Copy link
Member

diehlpk commented Jul 9, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 9, 2021

OK, I've started the review over in #3465.

@whedon whedon closed this as completed Jul 9, 2021
@diehlpk
Copy link
Member

diehlpk commented Jul 9, 2021

@elwinter Luckily, I found enough reviewers and I started the review.

@elwinter
Copy link

elwinter commented Jul 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diehlpk diehlpk

@hayesall hayesall

@taless474 taless474

Labels
Makefile pre-review Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests