Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: HARDy: Handling Arbitrary Recognition of Data in Python #3229

Closed
whedon opened this issue Apr 30, 2021 · 45 comments
Closed

[PRE REVIEW]: HARDy: Handling Arbitrary Recognition of Data in Python #3229

whedon opened this issue Apr 30, 2021 · 45 comments
Assignees
@gkthiruvathukal @alberto-battistel @andrewtarzia
Labels
pre-review Python TeX

Comments

@whedon
Copy link

whedon commented Apr 30, 2021 •
edited
Loading

Submitting author: @MariaPoliti (Maria Politi)
Repository: https://github.com/EISy-as-Py/hardy
Version: v1.0
Editor: @gkthiruvathukal
Reviewers: @andrewtarzia, @alberto-battistel
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @MariaPoliti. Currently, there isn't an JOSS editor assigned to your paper.

@MariaPoliti if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 30, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Apr 30, 2021 

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.16 s (406.6 files/s, 79897.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          30            846           1884           2657
Markdown                        10            185              0            559
YAML                            11            112            134            482
Jupyter Notebook                 4              0           5756            133
reStructuredText                 9             81             90            118
TeX                              1              7              0             68
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            67           1243           7872           4052
-------------------------------------------------------------------------------


Statistical information for the repository 'ac846e0a300aec2640405689' was
gathered on 2021/04/30.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Abdul Moeez                      1            51             62            0.14
David Hurt                      55          3545           1093            5.76
Maria Politi                    89         19618           4301           29.72
MariaPoliti                      7           222            425            0.80
Moeez                            2             2              2            0.00
amoeezuw                       132         26151          25008           63.57

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Abdul Moeez                  20           39.2         11.3               20.00
David Hurt                  970           27.4         11.0               15.77
Maria Politi               2725           13.9         10.0                7.08
amoeezuw                   1677            6.4          8.3               13.18

@whedon
Copy link
Author

whedon commented Apr 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Apr 30, 2021 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1021/acs.chemmater.9b03043.s001 may be a valid DOI for title: Enabling catalyst discovery through machine learning and high-throughput experimentation
- 10.1109/dsaa.2015.7344858 may be a valid DOI for title: Deep feature synthesis: Towards automating data science endeavors
- 10.1107/s1600576720000552 may be a valid DOI for title: Classifying and analyzing small‐angle scattering data using weighted k nearest neighbors machine learning techniques

INVALID DOIs

- None

@MariaPoliti
Copy link

MariaPoliti commented Apr 30, 2021 via email

@MariaPoliti
Copy link

MariaPoliti commented Apr 30, 2021 via email

@MariaPoliti
Copy link

MariaPoliti commented Apr 30, 2021 via email

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@whedon
Copy link
Author

whedon commented Apr 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@MariaPoliti
Copy link

MariaPoliti commented Apr 30, 2021 via email

@whedon
Copy link
Author

whedon commented Apr 30, 2021 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1021/acs.chemmater.9b03043.s001 is OK
- 10.1002/aenm.201900555 is OK
- 10.1109/dsaa.2015.7344858 is OK
- 10.24963/ijcai.2017/352 is OK
- 10.1107/s1600576720000552 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 30, 2021
@Kevin-Mattheus-Moerman
Copy link
Member

@gkthiruvathukal @arokem @terrytangyuan this seems like your cup of tea to potentially handle as editor but I see you all have a lot on your plate at the moment. I'll add the waitlisted label for now until one of you becomes available.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Apr 30, 2021 •
edited
Loading

@MariaPoliti as you can see I've added the waitlisted label as none of our editors, which appear most suitable for this submission, are currently available. We will continue to assign an editor once one in this domain becomes available. Thanks for your patience.

@gkthiruvathukal
Copy link

@Kevin-Mattheus-Moerman I think I can take this one! It looks interesting! I will go ahead and assign myself.

@gkthiruvathukal
Copy link

@whedon assign @gkthiruvathukal as editor

@whedon
Copy link
Author

whedon commented May 1, 2021

OK, the editor is @gkthiruvathukal

@gkthiruvathukal
Copy link

@MariaPoliti Can you please take a look at the list of people who can review for JOSS and suggest 2-4 of them? This will greatly help me to get the review process started.

@MariaPoliti
Copy link

MariaPoliti commented May 1, 2021 via email

@gkthiruvathukal
Copy link

@MariaPoliti Thank you. I will get on this shortly!

@gkthiruvathukal
Copy link

@tacaswell, are you willing to contribute a review for this JOSS submission?

@gkthiruvathukal
Copy link

@rmsare, are you willing to contribute a review for this JOSS submission?

@tacaswell
Copy link

I will not have any time until June.

@rmsare
Copy link

rmsare commented May 16, 2021 via email

@gkthiruvathukal
Copy link

@tacaswell That works for my timeframe. We're still in reduced service mode here. I will work with your schedule and try to keep it as low-stress as possible. Same for you, @rmsare, if you are willing to work on June/July timeframe.

Thanks for responding.

@gkthiruvathukal
Copy link

@tacaswell Just following up. It's hard to believe we are approaching end of June, so I hope this works well with your availability. Are you available to help with this review?

@gkthiruvathukal
Copy link

@yxoos Would you be willing to contribute a review for this JOSS submission? I need two reviewers, so I am hoping you and @tacaswell can help me out!

@amirhszd
Copy link

amirhszd commented Jun 28, 2021 via email

@MariaPoliti
Copy link

@gkthiruvathukal In case you need additional reviewers, I have identified a few others:

  • andrewtarzia
  • magedhelmy1
  • michaelberks
  • alberto-battistel

I hope this helps!

@gkthiruvathukal
Copy link

@MariaPoliti Thank you! I will try others now.

@gkthiruvathukal
Copy link

@andrewtarzia Would you be willing to contribute a review for this JOSS submission? I need two reviewers, so I hope you can help us here.

@gkthiruvathukal
Copy link

@michaelberks Would you be willing to contribute a review for this JOSS submission? I need two reviewers, so I hope you can help us here.

@andrewtarzia
Copy link

@gkthiruvathukal I would be keen to review, but as this would be my first time and I am about to travel, I would not expect to have this done before September. Is this ok?

Andrew

@andrewtarzia
Copy link

Started to review this. Lacks usage introduction. If there is a compiled documentation, it is not accessible.

Added an issue for the example notebook not working: EISy-as-Py/hardy#6

Interested in training timing: EISy-as-Py/hardy#7

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 28, 2021
@andrewtarzia
Copy link

Are we waiting on a second reviewer for this paper?

@gkthiruvathukal
Copy link

@andrewtarzia Yes. By the way, I haven't formally added you yet. Kind of a rough start to my academic year here but things improving. I will work to get a second and then we can get started.

@gkthiruvathukal
Copy link

@alberto-battistel Are you willing to help review this JOSS submission?

@gkthiruvathukal
Copy link

@whedon assign @andrewtarzia as reviewer

@whedon
Copy link
Author

whedon commented Oct 14, 2021

OK, @andrewtarzia is now a reviewer

@alberto-battistel
Copy link

@gkthiruvathukal Yes, I am willing to help review this submission. It is not exactly my topic but I will do my best!

@gkthiruvathukal
Copy link

@whedon add @alberto-battistel as reviewer

@whedon
Copy link
Author

whedon commented Oct 16, 2021

OK, @alberto-battistel is now a reviewer

@gkthiruvathukal
Copy link

Thank you, @alberto-battistel.

@gkthiruvathukal
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Oct 16, 2021

OK, I've started the review over in #3829.

@whedon whedon closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkthiruvathukal gkthiruvathukal

@alberto-battistel alberto-battistel

@andrewtarzia andrewtarzia

Labels
pre-review Python TeX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@tacaswell @gkthiruvathukal @danielskatz @rmsare @Kevin-Mattheus-Moerman @alberto-battistel @whedon @andrewtarzia @amirhszd @MariaPoliti