-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Makie.jl: Flexible high-performance data visualization for Julia #3226
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
@whedon assign @Kevin-Mattheus-Moerman as editor |
OK, the editor is @Kevin-Mattheus-Moerman |
PDF failed to compile for issue #3226 with the following error:
|
|
Our system cannot find the paper. Where can we find it? The repository for this submission is listed as: https://github.com/JuliaPlots/AbstractPlotting.jl is that correct or should it be https://github.com/JuliaPlots/Makie.jl ? Thanks |
The paper is in the I can also move it to |
@whedon generate pdf from branch joss-paper |
|
OK, @fverdugo is now a reviewer |
@whedon add @gaelforget as reviewer |
OK, @gaelforget is now a reviewer |
@cormullion @rdeits would you be interested in reviewing this work for JOSS? The review focuses on both the software and this short paper. Let me know if you are interested or have questions about what it means to review for JOSS. FYI we can give reviewers quite a lot of extra time at the moment (we all do) so just to let us know if you need lots to help with the review. |
Nice paper. I can see little that could be improved or needs comment - I would however rephrase the sentence at lines 21-24, which looks like it's missing something:
I won't be able to say anything about the software. |
@whedon add @logankilpatrick as reviewer |
OK, @logankilpatrick is now a reviewer |
@Kevin-Mattheus-Moerman I'm not sure if it makes a difference, but @logankilpatrick has contributed to Makie before. It's only a couple of commits I think, but maybe that is still a conflict. |
@jkrumbiegel apologies for the delay in getting back to you. Thanks for raising that, since he is not a co-author, and if the commits are relatively small, then in this case it sounds like it could be okay. @logankilpatrick can you comment on this too? |
After a discussion with the editorial board we decided that contribution does constitute a conflict of interest. We will therefore proceed to remove @logankilpatrick as a reviewer. @logankilpatrick thanks for offering to help. We'd love your help reviewing other packages for JOSS in the future if you are available. |
@whedon remove @logankilpatrick as reviewer |
OK, @logankilpatrick is no longer a reviewer |
@jkrumbiegel @gaelforget @fverdugo I will now initiate the review process. |
@whedon start review |
OK, I've started the review over in #3349. |
Submitting author: @jkrumbiegel (Julius Krumbiegel)
Repository: https://github.com/JuliaPlots/AbstractPlotting.jl
Version: v.0.17.4
Editor: @Kevin-Mattheus-Moerman
Reviewers: @fverdugo, @gaelforget
Managing EiC: Kevin M. Moerman
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Author instructions
Thanks for submitting your paper to JOSS @jkrumbiegel. Currently, there isn't an JOSS editor assigned to your paper.
The author's suggestion for the handling editor is @Kevin-Mattheus-Moerman.
@jkrumbiegel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: