Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Makie.jl: Flexible high-performance data visualization for Julia #3226

Closed
whedon opened this issue Apr 30, 2021 · 26 comments
Closed

Comments

@whedon
Copy link

whedon commented Apr 30, 2021

Submitting author: @jkrumbiegel (Julius Krumbiegel)
Repository: https://github.com/JuliaPlots/AbstractPlotting.jl
Version: v.0.17.4
Editor: @Kevin-Mattheus-Moerman
Reviewers: @fverdugo, @gaelforget
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @jkrumbiegel. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @Kevin-Mattheus-Moerman.

@jkrumbiegel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 30, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Apr 30, 2021

OK, the editor is @Kevin-Mattheus-Moerman

@whedon
Copy link
Author

whedon commented Apr 30, 2021

PDF failed to compile for issue #3226 with the following error:

 Can't find any papers to compile :-(

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.41 s (508.8 files/s, 79632.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          124           3956           1383          20351
Markdown                        70           1887              0           4598
YAML                             9              6             10            217
TOML                             5              5              0            142
-------------------------------------------------------------------------------
SUM:                           208           5854           1393          25308
-------------------------------------------------------------------------------


Statistical information for the repository '809ea6b415bc7da9cd231471' was
gathered on 2021/04/30.
No commited files with the specified extensions were found.

@whedon whedon added the Julia label Apr 30, 2021
@Kevin-Mattheus-Moerman
Copy link
Member

@jkrumbiegel

Our system cannot find the paper. Where can we find it? The repository for this submission is listed as: https://github.com/JuliaPlots/AbstractPlotting.jl is that correct or should it be https://github.com/JuliaPlots/Makie.jl ?

Thanks

@jkrumbiegel
Copy link

The paper is in the joss-paper branch in AbstractPlotting.jl https://github.com/JuliaPlots/AbstractPlotting.jl/tree/joss-paper

I can also move it to Makie.jl if you prefer, but AbstractPlotting is actually the main repository for the Makie ecosystem, due to historical reasons. It could be that we move everything from AbstractPlotting.jl to Makie.jl in the future as part of a restructuring effort.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Apr 30, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @fverdugo as reviewer

@whedon
Copy link
Author

whedon commented May 1, 2021

OK, @fverdugo is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @gaelforget as reviewer

@whedon
Copy link
Author

whedon commented May 1, 2021

OK, @gaelforget is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented May 1, 2021

@cormullion @rdeits would you be interested in reviewing this work for JOSS? The review focuses on both the software and this short paper.

Let me know if you are interested or have questions about what it means to review for JOSS.

FYI we can give reviewers quite a lot of extra time at the moment (we all do) so just to let us know if you need lots to help with the review.

@cormullion
Copy link

Nice paper. I can see little that could be improved or needs comment - I would however rephrase the sentence at lines 21-24, which looks like it's missing something:

To effectively understand and communicate results, different disciplines ranging from [... ? ...] publication-quality static vector graphics, through animated movies , to interactive data exploration tools, require flexible and powerful plotting software.

I won't be able to say anything about the software.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @logankilpatrick as reviewer

@whedon
Copy link
Author

whedon commented May 1, 2021

OK, @logankilpatrick is now a reviewer

@jkrumbiegel
Copy link

@Kevin-Mattheus-Moerman I'm not sure if it makes a difference, but @logankilpatrick has contributed to Makie before. It's only a couple of commits I think, but maybe that is still a conflict.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Jun 5, 2021

@jkrumbiegel apologies for the delay in getting back to you. Thanks for raising that, since he is not a co-author, and if the commits are relatively small, then in this case it sounds like it could be okay. @logankilpatrick can you comment on this too?

@Kevin-Mattheus-Moerman
Copy link
Member

After a discussion with the editorial board we decided that contribution does constitute a conflict of interest. We will therefore proceed to remove @logankilpatrick as a reviewer.

@logankilpatrick thanks for offering to help. We'd love your help reviewing other packages for JOSS in the future if you are available.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon remove @logankilpatrick as reviewer

@whedon
Copy link
Author

whedon commented Jun 9, 2021

OK, @logankilpatrick is no longer a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@jkrumbiegel @gaelforget @fverdugo I will now initiate the review process.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Jun 9, 2021

OK, I've started the review over in #3349.

@whedon whedon closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants