-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: eemont: A Python package that extends Google Earth Engine #3168
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @giswqs, @elbeejay, @patrickcgray it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
@giswqs, @elbeejay, @patrickcgray - thanks for agreeing to review this submission to JOSS. In the prior comments there is a checklist that you can use to guide you through your review. We have an automatic reminder set up in two weeks to ask you how the review is going. At present we request that reviewers complete their reviews within 6 weeks. JOSS is trying to be mindful of changes people have experienced due to COVID-19. As you work through your review, if there are any issues that come up, please make an issue in the eemont repository, and link to this issue (/issues/3168). That way most of the discussion can occur on in-repo issues. If you have any questions, please let me know (tag me here or email [email protected]). |
/ooo April 15 until April 20 |
FYI, I will be out of the office from April 15 until April 20. The ooo bot should respond indicating this if you tag me during that time. I will respond to any comments once I return. |
👋 @elbeejay, please update us on how your review is going (this is an automated reminder). |
👋 @patrickcgray, please update us on how your review is going (this is an automated reminder). |
👋 @giswqs, please update us on how your review is going (this is an automated reminder). |
I've gone though the package and opened up a few issues (#18 and #19 in the But overall I think the |
@elbeejay thanks for completing your review and identifying those issues. If @giswqs or @patrickcgray have questions as you work on your reviews, please let me know. |
@whedon generate pdf |
I just released geemap v0.8.15, which should help resolve the issue raised in davemlz/eemont#18 regarding the eemont tutorial notebooks. |
Hi to everyone! Following @elbeejay suggestions (davemlz/eemont#19), I have modified the paper (davemlz/eemont@5e50b13) with new sections (including the GEE Community: Developer Resources and the integration with the Earth Engine Plugin for QGIS), benefits of the package (including comparisons with the Earth Engine Python API), and I adjusted it for the State of the Field. |
@whedon generate pdf |
@davemlz I've made two pull requests with very small changes to the text and the .bib file. Please consider these PRs. After you have done so, please test that the article builds correctly here, and presuming it does do the following:
I can then move forward with accepting the submission. Know also that I'll be out of the office June 3-June 8. |
@davemlz FYI, I will be out of the office Thursday June 3-Tuesday June 8. |
Hi, @kbarnhart! Sorry for the late response, I'll start with it! |
@whedon generate pdf |
@whedon check references |
|
Hi, @kbarnhart! The package is now in Zenodo:
|
@whedon set 10.5281/zenodo.4900067 as archive |
OK. 10.5281/zenodo.4900067 is the archive. |
@whedon set v0.2.0 as version |
OK. v0.2.0 is the version. |
@whedon recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2377 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2377, then you can now move forward with accepting the submission by compiling again with the flag
|
@davemlz I've now recommended that this submission be accepted. One of the @openjournals/joss-eics will handle the final steps of this process. Congratulations on a valuable contribution. Many thanks to reviewers @giswqs, @elbeejay, @patrickcgray for you thoughtful and constructive reviews. |
Everything looks great! Ready to go! |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @davemlz! Thank you to editor @kbarnhart and reviewers @giswqs, @elbeejay, and @patrickcgray for your hard work and expertise! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you very much, @kbarnhart and @kthyng, it looks amazing! Big thanks to @elbeejay, @giswqs, @patrickcgray for the awesome help with the eemont review! |
Submitting author: @davemlz (David Montero Loaiza)
Repository: https://github.com/davemlz/eemont
Version: v0.2.0
Editor: @kbarnhart
Reviewer: @giswqs, @elbeejay, @patrickcgray
Archive: 10.5281/zenodo.4900067
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@giswqs & @elbeejay & @patrickcgray, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kbarnhart know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @giswqs
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @elbeejay
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @patrickcgray
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: