-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: seaborn: statistical data visualization #3021
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dangeles, @Sara-ShiHo it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #3021 with the following error: Can't find any papers to compile :-( |
|
@whedon generate pdf from branch joss_paper |
|
👋 @dangeles, please update us on how your review is going (this is an automated reminder). |
👋 @Sara-ShiHo, please update us on how your review is going (this is an automated reminder). |
@dangeles, @Sara-ShiHo, any updates on this? could you provide a date for when you will be able to work on this, please? Thanks! |
Hi @lpantano - thanks for checking in. I will show some progress via the checklist this week. I will have it completed by the 18th. |
Hi @whedon @lpantano is it possible to resend the invitation at https://github.com/openjournals/joss-reviews/invitations. I think the invitation has expired for me. Thank you. |
@whedon re-invite @Sara-ShiHo as reviewer |
OK, the reviewer has been re-invited. @Sara-ShiHo please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
OK, the reviewer has been re-invited. @dangeles please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
@mwaskom, can you address this issue raised by @Sara-ShiHo:
I think after that, it would be ready to be accepted. Thanks! |
@lpantano sure, sounds good. Also a couple of people who have seen the draft manuscript have suggested that it might make sense for a paper about a data visualization library to have an example data visualization. I guess that's reasonable. Would it make sense to add one at this stage? |
OK I added two commits: mwaskom/seaborn@6494515 addresses the target audience. seaborn is domain-general so the target audience is pretty wide; mwaskom/seaborn@7859883 adds an example script and figure. This seems useful, but I'm happy to revert it if you think it's too late in the process to add it. |
@whedon generate pdf from branch joss_paper |
|
Thank you, it is ok to add more information. @Sara-ShiHo can you check the update and update the item you didn't check because it was missing or give more feedback? Thanks! |
👋 @mwaskom - there are two minor changes in mwaskom/seaborn#2542, one of which might not matter... If you can merge this, I can go ahead and publish the paper |
Thanks @danielskatz for the PR! Merged. |
@whedon accept from branch joss_review |
|
|
@whedon accept from branch joss_review |
|
|
@whedon accept from branch joss_review |
|
|
@mwaskom - apologies for the fussing with your BibTeX file but could you also merge this PR? mwaskom/seaborn#2544 I think the BibTeX library we're using has a bug with whitespace. |
Done! |
@whedon accept from branch joss_review |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2189 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2189, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true from branch joss_review |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @mwaskom (Michael Waskom)!! And thanks to @dangeles and @Sara-ShiHo for reviewing, and @lpantano for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mwaskom (Michael Waskom)
Repository: https://github.com/mwaskom/seaborn
Version: v0.11.1
Editor: @lpantano
Reviewer: @dangeles, @Sara-ShiHo
Archive: 10.5281/zenodo.4645478
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dangeles & @Sara-ShiHo, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lpantano know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @dangeles
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @Sara-ShiHo
Conflict of interest
Code of Conduct
General checks
matplotlib
andpandas
Functionality
matplotlib
"add-ons"Documentation
Software paper
The text was updated successfully, but these errors were encountered: