Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GeophysicalFlows.jl: Solvers for geophysical fluid dynamics problems in periodic domains on CPUs & GPUs #2996

Closed
whedon opened this issue Jan 30, 2021 · 36 comments
Assignees

Comments

@whedon
Copy link

whedon commented Jan 30, 2021

Submitting author: @navidcy (Navid C. Constantinou)
Repository: https://github.com/FourierFlows/GeophysicalFlows.jl
Version: v0.11.3
Editor: @pdebuyl
Reviewers: @ranocha, @eviatarbach
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @navidcy. Currently, there isn't an JOSS editor assigned to your paper.

@navidcy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 30, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.48 s (97.9 files/s, 18287.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           25           1721            498           4898
Markdown                        13            419              0           1047
YAML                             6             17              8            115
TOML                             3              6              0             53
-------------------------------------------------------------------------------
SUM:                            47           2163            506           6113
-------------------------------------------------------------------------------


Statistical information for the repository '0dbbb2628f154e88c486304b' was
gathered on 2021/01/30.
No commited files with the specified extensions were found.

@whedon whedon added the Julia label Jan 30, 2021
@whedon
Copy link
Author

whedon commented Jan 30, 2021

PDF failed to compile for issue #2996 with the following error:

Can't find any papers to compile :-(

@danielskatz
Copy link

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jan 30, 2021

PDF failed to compile for issue #2996 with the following error:

Can't find any papers to compile :-(

@navidcy
Copy link

navidcy commented Jan 30, 2021

@whedon generate pdf from branch JOSS-paper

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Attempting PDF compilation from custom branch JOSS-paper. Reticulating splines etc...

@navidcy
Copy link

navidcy commented Jan 30, 2021

potential reviewers: rabernat, francispoulin, datseris, kburns, cesar-rocha

@whedon
Copy link
Author

whedon commented Jan 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

@whedon check references from branch JOSS-paper

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Attempting to check references... from custom branch JOSS-paper

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.4460734 is OK
- 10.5670/oceanog.2016.66 is OK
- 10.1103/PhysRevResearch.2.023068 is OK
- 10.5281/zenodo.3551326 is OK
- 10.5802/smai-jcm.63 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

👋 @leouieda - would you be able to edit this submission?

@danielskatz
Copy link

@whedon invite @leouieda as editor

@whedon
Copy link
Author

whedon commented Jan 30, 2021

@leouieda has been invited to edit this submission.

@navidcy
Copy link

navidcy commented Jan 30, 2021

extended list of potential reviewers:
rabernat, francispoulin, datseris, kburns,
cesar-rocha, gasagna, johnfgibson, jsoishi,
edoddridge, callumrollo

@navidcy
Copy link

navidcy commented Jan 30, 2021

@whedon generate pdf from branch JOSS-paper

@whedon
Copy link
Author

whedon commented Jan 30, 2021

Attempting PDF compilation from custom branch JOSS-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jan 30, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hi @leouieda, just wanted to ping you on this edit request

@pdebuyl
Copy link

pdebuyl commented Feb 9, 2021

@kyleniemeyer I can edit this

@kyleniemeyer
Copy link

Thanks @pdebuyl!

@kyleniemeyer
Copy link

@whedon assign @pdebuyl as editor

@whedon
Copy link
Author

whedon commented Feb 9, 2021

OK, the editor is @pdebuyl

@pdebuyl
Copy link

pdebuyl commented Feb 11, 2021

@whedon assign @ranocha as reviewer

@whedon whedon assigned pdebuyl and ranocha and unassigned pdebuyl Feb 11, 2021
@whedon
Copy link
Author

whedon commented Feb 11, 2021

OK, @ranocha is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Feb 17, 2021

Hi @navidcy , I am still looking for a second reviewer. Your can suggest a reviewer (with no conflict of interest) which I may consider if my current search is not fruitful.

@pdebuyl pdebuyl closed this as completed Feb 17, 2021
@pdebuyl
Copy link

pdebuyl commented Feb 17, 2021

Sorry, hit the close button by accident.

@pdebuyl pdebuyl reopened this Feb 17, 2021
@navidcy
Copy link

navidcy commented Feb 17, 2021

dpsanders, briochemc, ChrisRackauckas, natgeo-wong

If I think of more I’ll add them.

@navidcy
Copy link

navidcy commented Feb 18, 2021

@pdebuyl I'm not sure if dkarrasch would be considered having COI because he has contributed to the repository (see FourierFlows/GeophysicalFlows.jl@a4d42fe).

@pdebuyl
Copy link

pdebuyl commented Feb 19, 2021

Hello @navidcy I have contacted other potential reviewers for the time being, so this should not be an issue. If I have to extend my search, I will consider the question.

@pdebuyl
Copy link

pdebuyl commented Feb 22, 2021

@whedon add @eviatarbach as reviewer

@whedon whedon assigned pdebuyl and ranocha and unassigned pdebuyl and ranocha Feb 22, 2021
@whedon
Copy link
Author

whedon commented Feb 22, 2021

OK, @eviatarbach is now a reviewer

@pdebuyl
Copy link

pdebuyl commented Feb 22, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 22, 2021

OK, I've started the review over in #3053.

@whedon whedon closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants