Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: RBF: An R package to compute a robust backfitting estimator for additive models #2929

Closed
whedon opened this issue Dec 26, 2020 · 56 comments
Closed

[PRE REVIEW]: RBF: An R package to compute a robust backfitting estimator for additive models #2929

whedon opened this issue Dec 26, 2020 · 56 comments
Assignees
@mikldk @mmrabe @mcavs
Labels
C pre-review R

Comments

@whedon
Copy link

whedon commented Dec 26, 2020 •
edited
Loading

Submitting author: @alemermartinez (Alejandra Martínez)
Repository: https://github.com/msalibian/RBF
Version: v2.0.1
Editor: @mikldk
Reviewers: @mcavs, @mmrabe
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @alemermartinez. Currently, there isn't an JOSS editor assigned to your paper.

@alemermartinez if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 26, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 26, 2020 

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.10 s (71.4 files/s, 40449.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2            221              0           1199
C                                2            100             42            620
R                                1             73            482            462
Rmd                              1             37            281            377
C/C++ Header                     1             13              2             54
-------------------------------------------------------------------------------
SUM:                             7            444            807           2712
-------------------------------------------------------------------------------


Statistical information for the repository '28c3de16dc3f4dcdc19e342f' was
gathered on 2020/12/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Matias Salibian Barr             1           700              0           82.45
Matias Salibian-Barr             4           140              9           17.55

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Matias Salibian-Barr        831          593.6          0.0                6.26

@whedon
Copy link
Author

whedon commented Dec 26, 2020

PDF failed to compile for issue #2929 with the following error:

Can't find any papers to compile :-(

@danielskatz
Copy link

@whedon generate pdf from branch joss

@whedon
Copy link
Author

whedon commented Dec 26, 2020 

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Dec 26, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

@whedon check references from branch joss

@whedon
Copy link
Author

whedon commented Dec 26, 2020 

Attempting to check references... from custom branch joss

@whedon
Copy link
Author

whedon commented Dec 26, 2020 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1467-9892.2006.00511.x is OK
- 10.1080/03610926.2013.815780 is OK
- 10.1007/s11749-016-0508-0 is OK
- 10.1080/10485252.2017.1369077 is OK
- 10.1080/01621459.1985.10478157 is OK
- 10.1016/0047-259X(89)90023-7 is OK
- 10.1214/aos/1176347115 is OK
- 10.1007/978-3-642-48425-4_18 is OK
- 10.1214/ss/1038425655 is OK
- 10.1109/78.80907 is OK
- 10.2307/2287576 is OK
- 10.1214/aos/1176350694 is OK
- 10.1201/9780203753781-6 is OK
- 10.2307/2337630 is OK
- 10.1016/0304-4076(86)90002-3 is OK
- 10.1007/978-1-4899-3242-6 is OK
- 10.1137/1109020 is OK
- 10.1093/biomet/asm064 is OK
- 10.1214/aos/1176325632 is OK
- 10.1080/02331889908802693 is OK
- 10.18637/jss.v023.i07 is OK
- 10.2307/2291003 is OK
- 10.1007/978-0-387-21706-2 is OK
- 10.1080/01621459.2016.1180986 is OK
- 10.18637/jss.v032.i10 is OK
- 10.18637/jss.v027.i08 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

👋 @alemermartinez - I'm unsure if this fits JOSS, so the editors will now discuss if it meets JOSS's scope for review, specifically to check the size/scholarly effort of the software. This normally would take about a week, but might take longer due to the holidays.

@danielskatz
Copy link

@whedon query scope

@whedon
Copy link
Author

whedon commented Dec 26, 2020

Submission flagged for editorial review.

@whedon whedon added the query-scope Submissions of uncertain scope for JOSS label Dec 26, 2020
@Kevin-Mattheus-Moerman
Copy link
Member

@alemermartinez I just reviewed your paper as part of the scope check. I noted the following typo: additve. If you make any changes to the paper that you want to update you can call @whedon generate pdf here to update the paper.

@alemermartinez
Copy link

alemermartinez commented Dec 29, 2020 via email

@whedon
Copy link
Author

whedon commented Dec 29, 2020

PDF failed to compile for issue #2929 with the following error:

Can't find any papers to compile :-(

@alemermartinez
Copy link

alemermartinez commented Dec 29, 2020 via email

@whedon
Copy link
Author

whedon commented Dec 29, 2020

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@alemermartinez
Copy link

alemermartinez commented Dec 29, 2020 via email

@whedon
Copy link
Author

whedon commented Dec 29, 2020 

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Dec 29, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer kyleniemeyer removed the query-scope Submissions of uncertain scope for JOSS label Dec 29, 2020
@arfon
Copy link
Member

arfon commented Jan 4, 2021

@whedon invite @mikldk as editor

👋 @mikldk - happy new year! Would you be willing to edit this submission for JOSS?

@whedon
Copy link
Author

whedon commented Jan 4, 2021

@mikldk has been invited to edit this submission.

@mikldk
Copy link

mikldk commented Jan 4, 2021

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jan 4, 2021

OK, the editor is @mikldk

@mikldk
Copy link

mikldk commented Jan 25, 2021

@whedon generate pdf from branch joss

@whedon
Copy link
Author

whedon commented Jan 25, 2021 

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jan 25, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mikldk
Copy link

mikldk commented Jan 25, 2021

@alemermartinez Thanks. Please check which references you actually use from refs.bib in the paper, and be sure that only those are included in the file and that they all have a DOI.

@alemermartinez
Copy link

alemermartinez commented Jan 26, 2021 via email

@whedon
Copy link
Author

whedon commented Jan 26, 2021 

Attempting to check references... from custom branch joss

@whedon
Copy link
Author

whedon commented Jan 26, 2021 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/10485252.2017.1369077 is OK
- 10.1016/0047-259X(89)90023-7 is OK
- 10.2307/2287576 is OK
- 10.1201/9780203753781-6 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@alemermartinez
Copy link

alemermartinez commented Jan 26, 2021 via email

@mikldk
Copy link

mikldk commented Jan 27, 2021

@fabian-s, @kellieotto: Would you be interested in reviewing this submission to The Journal of Open Source Software? Reviews are open and based on a checklist. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you have any questions or concerns please let me know.

@fabian-s
Copy link

sorry, too much else on my plate ATM :(

@mikldk
Copy link

mikldk commented Jan 27, 2021

@mcavs: Would you be interested in reviewing this submission to The Journal of Open Source Software? Reviews are open and based on a checklist. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you have any questions or concerns please let me know.

@kellieotto
Copy link

@mikldk sorry, unfortunately I don't have the time after work to commit to doing a review right now. I hope to get back to doing reviews soon.

@mikldk
Copy link

mikldk commented Jan 28, 2021

@mmrabe: Would you be interested in reviewing this submission to The Journal of Open Source Software? Reviews are open and based on a checklist. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If you have any questions or concerns please let me know.

@mcavs
Copy link

mcavs commented Jan 28, 2021

@mikldk sure!

@mikldk
Copy link

mikldk commented Jan 28, 2021

@whedon add @mcavs as reviewer

@whedon whedon assigned mcavs and mikldk and unassigned mikldk Jan 28, 2021
@whedon
Copy link
Author

whedon commented Jan 28, 2021

OK, @mcavs is now a reviewer

@mmrabe
Copy link

mmrabe commented Jan 28, 2021

@mikldk I'd be happy to review this one.

@mikldk
Copy link

mikldk commented Jan 28, 2021

@whedon add @mmrabe as reviewer

@whedon whedon unassigned mikldk and mcavs Jan 28, 2021
@whedon
Copy link
Author

whedon commented Jan 28, 2021

OK, @mmrabe is now a reviewer

@mikldk
Copy link

mikldk commented Jan 28, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Jan 28, 2021

OK, I've started the review over in #2992.

@whedon whedon closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikldk mikldk

@mmrabe mmrabe

@mcavs mcavs

Labels
C pre-review R
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests