Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Autosubmit GUI: A Javascript-based Graphical User Interface to Monitor Experiments Workflow Execution #2924

Closed
whedon opened this issue Dec 22, 2020 · 48 comments

Comments

@whedon
Copy link

whedon commented Dec 22, 2020

Submitting author: @wuruchi (Wilmer Uruchi Ticona)
Repository: https://earth.bsc.es/gitlab/wuruchi/autosubmitreact
Version: v1.0.0
Editor: @arfon
Reviewers: @djmitche
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @wuruchi. Currently, there isn't an JOSS editor assigned to your paper.

@wuruchi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 22, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Dec 22, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/HPCSim.2016.7568429 is OK
- 10.5194/gmd-10-19-2017 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Dec 22, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

@whedon check repository

@danielskatz
Copy link

danielskatz commented Dec 22, 2020

👋 @openjournals/dev - any thoughts on why 👆 doesn't work?

@danielskatz
Copy link

danielskatz commented Dec 22, 2020

👋 @wuruchi - I'm unsure if this fits JOSS, so the editors will now discuss if it meets JOSS's scope for review, specifically to make sure that we consider it research software (and also possible to check the size/scholarly effort of the software). This normally would take about a week, but might take longer due to the holidays.

@danielskatz
Copy link

@whedon query scope

@whedon whedon added the query-scope Submissions of uncertain scope for JOSS label Dec 22, 2020
@whedon
Copy link
Author

whedon commented Dec 22, 2020

Submission flagged for editorial review.

@whedon
Copy link
Author

whedon commented Dec 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=199.57 s (130.4 files/s, 17373.8 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
JavaScript                           18443         332909         352433        1848572
JSON                                  2832            296              0         369561
Markdown                              2179          88917              4         220358
HTML                                   312          18648            405          64383
TypeScript                            1768           8268          44195          53475
CSS                                    104           1297           2642          20501
C/C++ Header                            42           1342            431           7073
C++                                     22           1292           1096           5645
D                                       20              0              0           5567
YAML                                   213            244            176           4207
XML                                      3            233             11           2011
CoffeeScript                            28            611             54           1649
LESS                                    13            272            745           1630
make                                    20            277            384            988
Bourne Shell                             8            194            132            936
Python                                   4             83            177            798
SVG                                      8             14              5            681
diff                                     1              3             13            588
Windows Module Definition                5             83              0            451
PHP                                      1             33             52             70
JSON5                                    1              0              0             55
TeX                                      1              7              0             46
Bourne Again Shell                       2             11              1             43
TOML                                     1              2              0             39
EJS                                      1              0              0              9
Lisp                                     1              0              0              6
DOS Batch                                1              0              0              2
---------------------------------------------------------------------------------------
SUM:                                 26034         455036         402956        2609344
---------------------------------------------------------------------------------------


Statistical information for the repository '662038724d77940241bd1d35' was
gathered on 2020/12/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Wilmer Uruchi Ticona            59       2258199         102129           61.43
bleudchanel                     68       1098792         375195           38.36
wuruchi                         14          6658           1550            0.21

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
bleudchanel             1084604           98.7          2.1               11.96
wuruchi                 1965759        29524.8          1.8               16.13

@danielskatz
Copy link

@openjournals/dev - never mind my request above - check repository just took a really long time...

@whedon
Copy link
Author

whedon commented Dec 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=391.01 s (66.6 files/s, 8867.6 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
JavaScript                           18443         332909         353806        1847199
JSON                                  2832            296              0         369561
Markdown                              2179          88917              4         220358
HTML                                   312          18648            405          64383
TypeScript                            1768           8268          44195          53475
CSS                                    104           1297           2642          20501
C/C++ Header                            42           1342            431           7073
C++                                     22           1292           1096           5645
D                                       20              0              0           5567
YAML                                   213            244            176           4207
XML                                      3            233             11           2011
CoffeeScript                            28            611             54           1649
LESS                                    13            272            745           1630
make                                    20            277            384            988
Bourne Shell                             8            194            132            936
Python                                   4             83            177            798
SVG                                      8             14              5            681
diff                                     1              3             13            588
Windows Module Definition                5             83              0            451
PHP                                      1             33             52             70
JSON5                                    1              0              0             55
TeX                                      1              7              0             46
Bourne Again Shell                       2             11              1             43
TOML                                     1              2              0             39
EJS                                      1              0              0              9
Lisp                                     1              0              0              6
DOS Batch                                1              0              0              2
---------------------------------------------------------------------------------------
SUM:                                 26034         455036         404329        2607971
---------------------------------------------------------------------------------------


Statistical information for the repository 'ab1e9a7db33ea546df362da7' was
gathered on 2020/12/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Wilmer Uruchi Ticona            59       2258199         102129           61.43
bleudchanel                     68       1098792         375195           38.36
wuruchi                         14          6658           1550            0.21

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
bleudchanel             1084604           98.7          2.1               11.96
wuruchi                 1965759        29524.8          1.8               16.13

@wuruchi
Copy link

wuruchi commented Dec 23, 2020

👋 @wuruchi - I'm unsure if this fits JOSS, so the editors will now discuss if it meets JOSS's scope for review, specifically to make sure that we consider it research software (and also possible to check the size/scholarly effort of the software). This normally would take about a week, but might take longer due to the holidays.

Hello @danielskatz. We will be waiting for the editors' answer and we are open to any request.

As a side note, the users bleudchanel and wuruchi are both my users. Author bleudchanel was introduced when I switched to working from home and forgot to update my git user. Wilmer Uruchi Ticona is just me.

Thank you for your time.

@arfon
Copy link
Member

arfon commented Dec 30, 2020

@openjournals/dev - never mind my request above - check repository just took a really long time...

Yeah, I think this is because clones from that server are really slooooooooow.

@wuruchi
Copy link

wuruchi commented Jan 7, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 7, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@wuruchi
Copy link

wuruchi commented Jan 7, 2021

@whedon commands

@whedon
Copy link
Author

whedon commented Jan 7, 2021

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@wuruchi
Copy link

wuruchi commented Jan 7, 2021

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 7, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng kthyng removed the query-scope Submissions of uncertain scope for JOSS label Jan 20, 2021
@kthyng
Copy link

kthyng commented Jan 20, 2021

Hi @wuruchi! The editorial board has decided that this submission is in scope, so we can proceed. Next step is to find a handling editor for your submission.

@kthyng
Copy link

kthyng commented Jan 20, 2021

@lorenanicole I know I pinged you on another submission to edit recently, but also wondering if you can take this one on.

@kthyng
Copy link

kthyng commented Jan 20, 2021

@whedon invite @lorenanicole as editor

@whedon
Copy link
Author

whedon commented Jan 20, 2021

@lorenanicole has been invited to edit this submission.

@wuruchi
Copy link

wuruchi commented Jan 21, 2021

Hello @kthyng

Hi @wuruchi! The editorial board has decided that this submission is in scope, so we can proceed. Next step is to find a handling editor for your submission.

Hello @kthyng. That is great news!

@kyleniemeyer
Copy link

Hello @lorenanicole, just pinging you again on this edit request. Thanks!

@arfon
Copy link
Member

arfon commented Feb 8, 2021

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Feb 8, 2021

OK, the editor is @arfon

@arfon
Copy link
Member

arfon commented Feb 8, 2021

👋 @wuruchi - apologies it has taken so long to assign an editor here. Many of our JOSS editors are extremely busy right now.

Could you take a look a this list of potential reviewers and identify a few people who would be good candidates to review this submission?

@wuruchi
Copy link

wuruchi commented Feb 9, 2021

Hello @arfon

No worries.

I think any of these reviewers could be a good choice:

@arfon
Copy link
Member

arfon commented Feb 17, 2021

👋 @ygrange @daissi @wjakethompson @vijaysm - would any of your be willing to review this submission for JOSS?

The submission under review is Autosubmit GUI: A Javascript-based Graphical User Interface to Monitor Experiments Workflow Execution.

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@wjakethompson
Copy link

I have no Javascript experience, so I'm not sure that I'd be a good fit for this one given that I have no idea what I'd be looking for 😄.

@desilinguist
Copy link

Same here. I can't really review JS code.

@daissi
Copy link

daissi commented Feb 17, 2021

Sorry, I don't have free time currently and no experience with Javascript.

@ygrange
Copy link

ygrange commented Feb 17, 2021

Same point on JS code as the others. I can, and am totally happy to, look at it functionality-wise and look at things like testing etc.

@djmitche
Copy link

Not to throw myself under a bus that others seem to be successfully avoiding, but .. I know a bit of React and a lot of JS and can take a look.

@vijaysm
Copy link

vijaysm commented Feb 18, 2021 via email

@arfon
Copy link
Member

arfon commented Feb 20, 2021

@djmitche - thanks so much! I'll go ahead and assign you now and start the review ✨

@arfon

This comment has been minimized.

@whedon
Copy link
Author

whedon commented Feb 20, 2021

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@arfon
Copy link
Member

arfon commented Feb 20, 2021

@whedon add @djmitche as reviewer

@whedon whedon assigned arfon and djmitche and unassigned arfon Feb 20, 2021
@whedon
Copy link
Author

whedon commented Feb 20, 2021

OK, @djmitche is now a reviewer

@arfon
Copy link
Member

arfon commented Feb 20, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 20, 2021

OK, I've started the review over in #3049.

@whedon whedon closed this as completed Feb 20, 2021
@arfon
Copy link
Member

arfon commented Feb 20, 2021

@RuneBlaze @ikayz - would either of your be willing to review this submission for JOSS?

The submission under review is Autosubmit GUI: A Javascript-based Graphical User Interface to Monitor Experiments Workflow Execution.

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@ikayz
Copy link

ikayz commented Feb 21, 2021

@arfon The issue has been closed does it still need a review?

@arfon
Copy link
Member

arfon commented Feb 21, 2021

@ikayz - we're still looking for a second reviewer if you're able to help out!

@ikayz
Copy link

ikayz commented Feb 21, 2021

@arfon sure thing though I don't think I'm part of the repo.

@arfon
Copy link
Member

arfon commented Feb 21, 2021

Ah OK. I've added you to the review over in #3049. Thanks again @ikayz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests