-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DeepReg: a deep learning toolkit for medical image registration #2705
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @ethanwharris, @lbrea, @zhangfanmark it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
@ethanwharris, @lbrea, @zhangfanmark, this is where the review takes place. There are instructions, and a set of checkboxes for each of you at the top of this issue which will guide you through the process. We would appreciate it if you could complete the review within about 2-3 weeks. Please let me know if you have any questions. Let the reviewing begin! 🎉 |
@lbrea, @zhangfanmark, could you please consider updating your GitHub profile with your full name, and preferably a link to a professional (e.g. university) profile, ORCID, or equivalent. |
@ethanwharris, @lbrea, @zhangfanmark, this is where the review takes place. I hope you are able to get started if you haven't already. Let me know if you have questions. |
@whedon generate pdf |
@whedon check references |
|
@whedon check references |
|
@Kevin-Mattheus-Moerman I have now finished my review. The authors have responded to my breif comments on the paper and the code base / documentation is in good shape (installation works and the demos run as expected etc.) so I recommend acceptance 😃 |
Thanks for your help @ethanwharris ! |
@lbrea, @zhangfanmark thanks again for agreeing to review this work. Can you let me know if you have started and when you expect to complete this review? Let me know if you have questions. |
Hi, sorry for the late reply. I am now working now on the review, and I
expect to complete it by Monday 26 at the latest.
…On Wed, Oct 21, 2020 at 10:04 PM Kevin Mattheus Moerman < ***@***.***> wrote:
@lbrea <https://github.com/lbrea>, @zhangfanmark
<https://github.com/zhangfanmark> thanks again for agreeing to review
this work. Can you let me know if you have started and when you expect to
complete this review? Let me know if you have questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2705 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMAQ7BR53KURSTGPDPQD5GDSL45ERANCNFSM4R46NN5A>
.
|
Sorry for the delay. I will perform the review and get it back early next week. |
@Kevin-Mattheus-Moerman I've finished my review (see further comments above). The package looks great to me, and I would recommend acceptance. |
Hi @zhangfanmark @lbrea, thank you so much for your reviews. We've addressed all the mentioned issues and please feel free to try again ;) |
@whedon generate pdf |
@ethanwharris, @zhangfanmark looks like you've ticked all boxes above. Can you review the latest changes and/or confirm you are happy to recommend acceptance of this work? |
Hi @Kevin-Mattheus-Moerman , the code and the paper look good to me. I recommend acceptance of the work. Thank you! |
Hi @Kevin-Mattheus-Moerman , all looks good to me, happy to recommend acceptance :) |
@whedon check references |
|
@mathpluscode this looks like it is ready to process for acceptance. At this point can you do the following:
Thanks |
Thanks! |
@whedon set 10.5281/zenodo.4210215 as archive |
OK. 10.5281/zenodo.4210215 is the archive. |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1892 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1892, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Hi, @Kevin-Mattheus-Moerman @ethanwharris @zhangfanmark @lbrea, thank you a lot for the edit and review! |
Great editorial service - will recommend to colleagues 👍 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mathpluscode (Yunguan Fu)
Repository: https://github.com/DeepRegNet/DeepReg
Version: v0.1.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @ethanwharris, @lbrea, @zhangfanmark
Archive: 10.5281/zenodo.4210215
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ethanwharris & @lbrea & @zhangfanmark, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @ethanwharris
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @lbrea
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @zhangfanmark
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: