Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: DeepReg: a deep learning toolkit for medical image registration #2705

Closed
60 tasks done
whedon opened this issue Sep 28, 2020 · 42 comments
Closed
60 tasks done
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review

Comments

@whedon
Copy link

whedon commented Sep 28, 2020

Submitting author: @mathpluscode (Yunguan Fu)
Repository: https://github.com/DeepRegNet/DeepReg
Version: v0.1.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @ethanwharris, @lbrea, @zhangfanmark
Archive: 10.5281/zenodo.4210215

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7e6de472bc82a70d7618e23f618960b3"><img src="https://joss.theoj.org/papers/7e6de472bc82a70d7618e23f618960b3/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7e6de472bc82a70d7618e23f618960b3/status.svg)](https://joss.theoj.org/papers/7e6de472bc82a70d7618e23f618960b3)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ethanwharris & @lbrea & @zhangfanmark, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Review checklist for @ethanwharris

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mathpluscode) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @lbrea

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mathpluscode) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @zhangfanmark

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mathpluscode) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Sep 28, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @ethanwharris, @lbrea, @zhangfanmark it looks like you're currently assigned to review this paper 🎉.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 28, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-32245-8_45 is OK
- 10.1016/j.media.2018.07.002 is OK
- 10.1109/ISBI.2018.8363756 is OK
- 10.1016/j.media.2018.11.010 is OK
- 10.1109/TMI.2019.2897538 is OK
- 10.1016/j.media.2019.07.006 is OK
- 10.1016/j.cmpb.2018.01.025 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1016/j.neuroimage.2007.07.007 is OK
- 10.1016/j.neuroimage.2008.10.040 is OK
- 10.1088/0031-9155/46/3/201 is OK
- 10.1007/s00138-020-01066-5 is OK
- 10.1088/1361-6560/ab843e is OK
- 10.1007/978-3-658-29267-6_53 is OK
- 10.1109/42.796284 is OK
- 10.5281/zenodo.3835682 is OK
- 10.1002/mp.12268 is OK
- 10.5281/zenodo.3715652 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 28, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@ethanwharris, @lbrea, @zhangfanmark, this is where the review takes place. There are instructions, and a set of checkboxes for each of you at the top of this issue which will guide you through the process. We would appreciate it if you could complete the review within about 2-3 weeks. Please let me know if you have any questions.

Let the reviewing begin! 🎉

@Kevin-Mattheus-Moerman
Copy link
Member

@lbrea, @zhangfanmark, could you please consider updating your GitHub profile with your full name, and preferably a link to a professional (e.g. university) profile, ORCID, or equivalent.

@arfon arfon changed the title [REVIEW]: https://joss.theoj.org/papers/new [REVIEW]: DeepReg: a deep learning toolkit for medical image registration Sep 29, 2020
@Kevin-Mattheus-Moerman
Copy link
Member

@ethanwharris, @lbrea, @zhangfanmark, this is where the review takes place. I hope you are able to get started if you haven't already. Let me know if you have questions.

@mathpluscode
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 5, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mathpluscode
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Oct 6, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-32245-8_45 is OK
- 10.1016/j.media.2018.07.002 is OK
- 10.1109/ISBI.2018.8363756 is OK
- 10.1016/j.media.2018.11.010 is OK
- 10.1109/TMI.2019.2897538 is OK
- 10.1016/j.media.2019.07.006 is OK
- 10.1016/j.cmpb.2018.01.025 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1016/j.neuroimage.2007.07.007 is OK
- 10.1016/j.neuroimage.2008.10.040 is OK
- 10.1088/0031-9155/46/3/201 is OK
- 10.1007/s00138-020-01066-5 is OK
- 10.1088/1361-6560/ab843e is OK
- 10.1007/978-3-658-29267-6_53 is OK
- 10.1109/42.796284 is OK
- 10.5281/zenodo.3835682 is OK
- 10.1002/mp.12268 is OK
- 10.5281/zenodo.3715652 is OK
- 10.1016/j.cmpb.2009.09.002 is OK
- 10.1109/CVPRW.2016.78 is OK

MISSING DOIs

- 10.1007/978-3-030-59716-0_24 may be a valid DOI for title: Longitudinal Image Registration with Temporal-order and Subject-specificity Discrimination
- 10.1007/978-3-030-59716-0_15 may be a valid DOI for title: MvMM-RegNet: A new image registration framework based on multivariate mixture model and neural network estimation

INVALID DOIs

- None

@mathpluscode
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Oct 8, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-32245-8_45 is OK
- 10.1016/j.media.2018.07.002 is OK
- 10.1109/ISBI.2018.8363756 is OK
- 10.1016/j.media.2018.11.010 is OK
- 10.1109/TMI.2019.2897538 is OK
- 10.1016/j.media.2019.07.006 is OK
- 10.1007/978-3-030-59716-0_24 is OK
- 10.1016/j.cmpb.2018.01.025 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1016/j.neuroimage.2007.07.007 is OK
- 10.1016/j.neuroimage.2008.10.040 is OK
- 10.1088/0031-9155/46/3/201 is OK
- 10.1007/s00138-020-01066-5 is OK
- 10.1088/1361-6560/ab843e is OK
- 10.1007/978-3-030-59716-0_15 is OK
- 10.1007/978-3-658-29267-6_53 is OK
- 10.1109/42.796284 is OK
- 10.5281/zenodo.3835682 is OK
- 10.1002/mp.12268 is OK
- 10.5281/zenodo.3715652 is OK
- 10.1016/j.cmpb.2009.09.002 is OK
- 10.1109/CVPRW.2016.78 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@ethanwharris
Copy link

@Kevin-Mattheus-Moerman I have now finished my review. The authors have responded to my breif comments on the paper and the code base / documentation is in good shape (installation works and the demos run as expected etc.) so I recommend acceptance 😃

@Kevin-Mattheus-Moerman
Copy link
Member

Thanks for your help @ethanwharris !

@Kevin-Mattheus-Moerman
Copy link
Member

@lbrea, @zhangfanmark thanks again for agreeing to review this work. Can you let me know if you have started and when you expect to complete this review? Let me know if you have questions.

@lbrea
Copy link

lbrea commented Oct 23, 2020 via email

@zhangfanmark
Copy link

Sorry for the delay. I will perform the review and get it back early next week.

@lbrea
Copy link

lbrea commented Oct 26, 2020

@Kevin-Mattheus-Moerman I've finished my review (see further comments above). The package looks great to me, and I would recommend acceptance.

@mathpluscode
Copy link

Hi @zhangfanmark @lbrea, thank you so much for your reviews. We've addressed all the mentioned issues and please feel free to try again ;)

@mathpluscode
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 28, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@ethanwharris, @zhangfanmark looks like you've ticked all boxes above. Can you review the latest changes and/or confirm you are happy to recommend acceptance of this work?

@zhangfanmark
Copy link

Hi @Kevin-Mattheus-Moerman , the code and the paper look good to me. I recommend acceptance of the work. Thank you!

@ethanwharris
Copy link

Hi @Kevin-Mattheus-Moerman , all looks good to me, happy to recommend acceptance :)

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon check references

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-32245-8_45 is OK
- 10.1016/j.media.2018.07.002 is OK
- 10.1109/ISBI.2018.8363756 is OK
- 10.1016/j.media.2018.11.010 is OK
- 10.1109/TMI.2019.2897538 is OK
- 10.1016/j.media.2019.07.006 is OK
- 10.1007/978-3-030-59716-0_24 is OK
- 10.1016/j.cmpb.2018.01.025 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1016/j.neuroimage.2007.07.007 is OK
- 10.1016/j.neuroimage.2008.10.040 is OK
- 10.1088/0031-9155/46/3/201 is OK
- 10.1007/s00138-020-01066-5 is OK
- 10.1088/1361-6560/ab843e is OK
- 10.1007/978-3-030-59716-0_15 is OK
- 10.1007/978-3-658-29267-6_53 is OK
- 10.1109/42.796284 is OK
- 10.5281/zenodo.3835682 is OK
- 10.1002/mp.12268 is OK
- 10.5281/zenodo.3715652 is OK
- 10.1016/j.cmpb.2009.09.002 is OK
- 10.1109/CVPRW.2016.78 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Nov 2, 2020

@mathpluscode this looks like it is ready to process for acceptance. At this point can you do the following:

  • Can you archive a copy of the reviewed software on Zenodo and report back here with the DOI? (some find this approach useful: https://guides.github.com/activities/citable-code/).

  • Please check that the Zenodo archive metadata like the title, authors, and version matches that of the paper. You may need to ammend/edit this information manually.

  • Can you confirm if v0.1.0 is the most appropriate version tag for this work, or has the version moved on?

Thanks

@mathpluscode
Copy link

mathpluscode commented Nov 2, 2020

@mathpluscode this looks like it is ready to process for acceptance. At this point can you do the following:

  • Can you archive a copy of the reviewed software on Zenodo and report back here with the DOI? (some find this approach useful: https://guides.github.com/activities/citable-code/).
  • Please check that the Zenodo archive metadata like the title, authors, and version matches that of the paper. You may need to ammend/edit this information manually.
  • Can you confirm if v0.1.0 is the most appropriate version tag for this work, or has the version moved on?

Thanks

Hi @Kevin-Mattheus-Moerman,

  • Here is the archive of DeepReg v0.1.0 DOI
  • Yes we've corrected the title, authors and version
  • Yes we confirm v0.1.0 is the correct version tag.

Thanks!

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon set 10.5281/zenodo.4210215 as archive

@whedon
Copy link
Author

whedon commented Nov 4, 2020

OK. 10.5281/zenodo.4210215 is the archive.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon accept

@whedon
Copy link
Author

whedon commented Nov 4, 2020

Attempting dry run of processing paper acceptance...

@whedon whedon added the recommend-accept Papers recommended for acceptance in JOSS. label Nov 4, 2020
@whedon
Copy link
Author

whedon commented Nov 4, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-32245-8_45 is OK
- 10.1016/j.media.2018.07.002 is OK
- 10.1109/ISBI.2018.8363756 is OK
- 10.1016/j.media.2018.11.010 is OK
- 10.1109/TMI.2019.2897538 is OK
- 10.1016/j.media.2019.07.006 is OK
- 10.1007/978-3-030-59716-0_24 is OK
- 10.1016/j.cmpb.2018.01.025 is OK
- 10.1109/CVPR.2016.90 is OK
- 10.1016/j.neuroimage.2007.07.007 is OK
- 10.1016/j.neuroimage.2008.10.040 is OK
- 10.1088/0031-9155/46/3/201 is OK
- 10.1007/s00138-020-01066-5 is OK
- 10.1088/1361-6560/ab843e is OK
- 10.1007/978-3-030-59716-0_15 is OK
- 10.1007/978-3-658-29267-6_53 is OK
- 10.1109/42.796284 is OK
- 10.5281/zenodo.3835682 is OK
- 10.1002/mp.12268 is OK
- 10.5281/zenodo.3715652 is OK
- 10.1016/j.cmpb.2009.09.002 is OK
- 10.1109/CVPRW.2016.78 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Nov 4, 2020

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#1892

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1892, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon accept deposit=true

@whedon
Copy link
Author

whedon commented Nov 4, 2020

Doing it live! Attempting automated processing of paper acceptance...

@whedon whedon added accepted published Papers published in JOSS labels Nov 4, 2020
@whedon
Copy link
Author

whedon commented Nov 4, 2020

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon
Copy link
Author

whedon commented Nov 4, 2020

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.02705 joss-papers#1893
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02705
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@mathpluscode
Copy link

Hi, @Kevin-Mattheus-Moerman @ethanwharris @zhangfanmark @lbrea, thank you a lot for the edit and review!

@YipengHu
Copy link

YipengHu commented Nov 4, 2020

Hi, @Kevin-Mattheus-Moerman @ethanwharris @zhangfanmark @lbrea, thank you a lot for the edit and review!

Great editorial service - will recommend to colleagues 👍

@whedon
Copy link
Author

whedon commented Nov 4, 2020

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02705/status.svg)](https://doi.org/10.21105/joss.02705)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02705">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02705/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02705/status.svg
   :target: https://doi.org/10.21105/joss.02705

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review
Projects
None yet
Development

No branches or pull requests

7 participants