Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: sbi - a toolkit for simulation-based inference #2486

Closed
whedon opened this issue Jul 18, 2020 · 19 comments
Closed

[PRE REVIEW]: sbi - a toolkit for simulation-based inference #2486

whedon opened this issue Jul 18, 2020 · 19 comments

Comments

@whedon
Copy link

whedon commented Jul 18, 2020

Submitting author: @janfb (Jan Boelts)
Repository: https://github.com/mackelab/sbi
Version: v0.10.0
Editor: @dfm
Reviewers: @EiffL, @cranmer
Managing EiC: Lorena A Barba

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @janfb. Currently, there isn't an JOSS editor assigned to your paper.

@janfb if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 18, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 18, 2020

PDF failed to compile for issue #2486 with the following error:

Can't find any papers to compile :-(

@whedon
Copy link
Author

whedon commented Jul 18, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.21 s (412.3 files/s, 63900.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          65           2061           2735           6544
Markdown                        10            162              0            465
Jupyter Notebook                 4              0           1124            150
YAML                             3             16             13            126
JSON                             2              0              0             98
JavaScript                       2             10              0             57
CSS                              1             11              7             47
SVG                              1              0              1             10
-------------------------------------------------------------------------------
SUM:                            88           2260           3880           7497
-------------------------------------------------------------------------------


Statistical information for the repository '2486' was gathered on 2020/07/18.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Alvaro Tejero-Canter            96          7536           7451           12.48
Conor Durkan                     1         13290              0           11.07
David Greenberg                  1             2              2            0.00
Harry Fu Yu                      1            10              9            0.02
Jan                             12          1206           2821            3.35
Jan-Matthis                     12           993            867            1.55
Michael Deistler                81         11643           7351           15.82
dgreenberg                       1            13              9            0.02
jan-matthis                     21         15553          14266           24.84
janfb                           76          6820           5528           10.28
meteore                          8          8364          15833           20.15
michael                          6           306            192            0.41

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Conor Durkan                702            5.3          0.0                9.83
Harry Fu Yu                  10          100.0          0.2                0.00
Jan                          70            5.8          4.9                4.29
Jan-Matthis                2362          237.9          2.2                6.39
Michael Deistler           2939           25.2          2.0                8.51
janfb                      2669           39.1          1.7                8.73
meteore                    2458           29.4          2.0               13.75
michael                     197           64.4          0.2               10.66

@labarba
Copy link
Member

labarba commented Jul 18, 2020

@whedon generate pdf from branch joss-submission

@whedon
Copy link
Author

whedon commented Jul 18, 2020

Attempting PDF compilation from custom branch joss-submission. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 18, 2020

@labarba
Copy link
Member

labarba commented Jul 18, 2020

@whedon invite @dfm as editor

@whedon
Copy link
Author

whedon commented Jul 18, 2020

@dfm has been invited to edit this submission.

@dfm
Copy link

dfm commented Jul 18, 2020

@labarba: I'm happy to edit this submission!

@dfm
Copy link

dfm commented Jul 18, 2020

@whedon assign @dfm as editor

@whedon
Copy link
Author

whedon commented Jul 18, 2020

OK, the editor is @dfm

@janfb
Copy link

janfb commented Jul 20, 2020

@dfm thanks for editing our submission!

@dfm
Copy link

dfm commented Jul 22, 2020

@EiffL and @cranmer have kindly agreed to review this submission. I'll add them and we'll get the review started in a new thread. Thanks all!

@dfm
Copy link

dfm commented Jul 22, 2020

@whedon assign @EiffL as reviewer

@whedon whedon unassigned dfm Jul 22, 2020
@whedon
Copy link
Author

whedon commented Jul 22, 2020

OK, @EiffL is now a reviewer

@dfm
Copy link

dfm commented Jul 22, 2020

@whedon add @cranmer as reviewer

@whedon whedon assigned dfm and unassigned dfm Jul 22, 2020
@whedon
Copy link
Author

whedon commented Jul 22, 2020

OK, @cranmer is now a reviewer

@dfm
Copy link

dfm commented Jul 22, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 22, 2020

OK, I've started the review over in #2505.

@whedon whedon closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants