Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: WDPM: the Wetland DEM Ponding Model #2234

Closed
whedon opened this issue May 23, 2020 · 48 comments
Closed

[PRE REVIEW]: WDPM: the Wetland DEM Ponding Model #2234

whedon opened this issue May 23, 2020 · 48 comments

Comments

@whedon
Copy link

whedon commented May 23, 2020

Submitting author: @KevinShook (Kevin Shook)
Repository: https://github.com/CentreForHydrology/WDPM
Version: v1.0.0
Editor: @kbarnhart
Reviewers: @r-barnes, @awickert, @KCallaghan
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @KevinShook. Currently, there isn't an JOSS editor assigned to your paper.

@KevinShook if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 23, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.13 s (60.7 files/s, 42276.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                                2            296            208           3294
Python                           1             82            251           1028
OpenCL                           1             23              6            156
TeX                              1             10              0             96
Markdown                         2             32              0             63
JSON                             1              0              0             23
-------------------------------------------------------------------------------
SUM:                             8            443            465           4660
-------------------------------------------------------------------------------


Statistical information for the repository '2234' was gathered on 2020/05/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Kevin Shook                      1          5159              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Kevin Shook                5159          100.0          0.0                9.01

@whedon
Copy link
Author

whedon commented May 23, 2020

Reference check summary:

OK DOIs

- 10.1002/hyp.8381 is OK
- 10.1002/hyp.9867 is OK
- 10.1016/j.jhydrol.2014.12.014 is OK
- 10.1016/S0022-1694(03)00175-6 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1002/hyp is INVALID

@whedon
Copy link
Author

whedon commented May 23, 2020

@arfon
Copy link
Member

arfon commented May 23, 2020

👋 @KevinShook - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 23, 2020
@KevinShook
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented May 23, 2020

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2020

@KevinShook
Copy link

@whedon generate proof

@whedon
Copy link
Author

whedon commented May 23, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2020

@KevinShook
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented May 23, 2020

Reference check summary:

OK DOIs

- 10.1002/hyp.6787 is OK
- 10.1002/hyp.8381 is OK
- 10.1002/hyp.9867 is OK
- 10.1016/j.jhydrol.2014.12.014 is OK
- 10.1016/S0022-1694(03)00175-6 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@KevinShook
Copy link

@whedon check repository

@whedon
Copy link
Author

whedon commented May 23, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.08 s (97.4 files/s, 67783.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                                2            296            208           3294
Python                           1             82            251           1028
OpenCL                           1             23              6            156
TeX                              1             10              0             96
Markdown                         2             32              0             63
JSON                             1              0              0             23
-------------------------------------------------------------------------------
SUM:                             8            443            465           4660
-------------------------------------------------------------------------------


Statistical information for the repository '2234' was gathered on 2020/05/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Kevin Shook                      1          5159              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Kevin Shook                5159          100.0          0.0                9.01

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2020

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 25, 2020

@kbarnhart
Copy link

@openjournals/joss-eics I can handle this one.

@kbarnhart
Copy link

@whedon assign @kbarnhart as editor

@whedon
Copy link
Author

whedon commented May 28, 2020

OK, the editor is @kbarnhart

@kbarnhart
Copy link

@whedon add @awickert as reviewer

@whedon whedon assigned awickert, kbarnhart and r-barnes and unassigned r-barnes and kbarnhart May 29, 2020
@whedon
Copy link
Author

whedon commented May 29, 2020

OK, @awickert is now a reviewer

@kbarnhart
Copy link

@whedon add @KCallaghan as reviewer

@whedon whedon assigned awickert and kbarnhart and unassigned awickert, r-barnes and kbarnhart May 29, 2020
@whedon
Copy link
Author

whedon commented May 29, 2020

OK, @KCallaghan is now a reviewer

@kbarnhart
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented May 29, 2020

OK, I've started the review over in #2276.

@whedon whedon closed this as completed May 29, 2020
@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 22, 2021

PDF failed to compile for issue #2234 with the following error:

/app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in parse': (a61e06cd2a4edf93b9d570d2/paper/paper.md): found a tab character that violate intendation while scanning a plain scalar at line 18 column 18 (Psych::SyntaxError) from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:456:in parse_stream'
from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:390:in parse' from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:277:in load'
from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:578:in block in load_file' from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in open'
from /app/vendor/ruby-2.6.6/lib/ruby/2.6.0/psych.rb:577:in load_file' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:127:in load_yaml'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon.rb:87:in initialize' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in new'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/processor.rb:38:in set_paper' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:58:in prepare'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/bin/whedon:131:in <top (required)>' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `

'

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 22, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@KevinShook
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 22, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Feb 23, 2021

Hi @KevinShook! You can test out your paper compilation, see here: https://joss.readthedocs.io/en/latest/submitting.html#checking-that-your-paper-compiles

@KevinShook
Copy link

Thanks - wasn't sure where to be running the whedon commands

@kthyng
Copy link

kthyng commented Feb 23, 2021

You can always just run the generate pdf command in the review issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants