-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: deepCR: Cosmic Ray Rejection with Deep Learning #1647
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
PDF failed to compile for issue #1647 with the following error: Could not find bibliography file: paper.bib |
@kmzzhang - There doesn't seem to be a paper.bib file in your repo |
Hello,
I have just included paper.bib in the repo.
Thanks,
Keming
On Aug 13, 2019, at 6:54 PM, Daniel S. Katz <[email protected]<mailto:[email protected]>> wrote:
@kmzzhang<https://github.com/kmzzhang> - There doesn't seem to be a paper.bib file in your repo
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1647?email_source=notifications&email_token=AJSWHVB2AIJ62IWWRBHFLVDQENQUXA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HO65A#issuecomment-521072500>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJSWHVFJQVIWQZGOTFTS2U3QENQUXANCNFSM4ILQH3JQ>.
|
@whedon generate pdf |
|
There's a misspelled |
👋 @terrytangyuan - would you be willing to review this submission? |
@whedon assign @terrytangyuan as editor |
OK, the editor is @terrytangyuan |
Sure, @kmzzhang do you have a list of potentials reviewers in mind? If so, please mention them here. |
@terrytangyuan, may I suggest nilesh-patil, DanielLenz, shreyasbapat as potential reviewers? They have listed both deep learning and astronomy as their expertise. Additionally, I don’t see the figure in the generated paper proof. Is the figure format wrong? Thanks.
|
I wonder if the path to the image is a problem? @arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs) |
Hi @nilesh-patil @DanielLenz @shreyasbapat Would you be interested in reviewing this submission? |
Yes sure! I can :) |
I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well. |
@kmzzhang - can you update the URL of the image to:
Also, can you confirm @kmzzhang that this is a joint submission with AAS? |
@whedon<https://github.com/whedon> generate pdf
On Aug 14, 2019, at 5:24 PM, Arfon Smith <[email protected]<mailto:[email protected]>> wrote:
I wonder if the path to the image is a problem? @arfon<https://github.com/arfon> - can you help with this? (since we can't see the generate pdf log to see any error msgs)
@kmzzhang<https://github.com/kmzzhang> - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?
I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.
Also, can you confirm @kmzzhang<https://github.com/kmzzhang> that this is a joint submission with AAS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1647?email_source=notifications&email_token=AJSWHVHJCWIN3GVRXCQ7O2DQESO4XA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KPM5A#issuecomment-521467508>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJSWHVHUCSAOWZRTWIQNIGTQESO4XANCNFSM4ILQH3JQ>.
|
you probably need to do this on github - doing it by email doesn't quite work |
Yes, this is a joint submission with AAS.
On Aug 14, 2019, at 5:24 PM, Arfon Smith <[email protected]<mailto:[email protected]>> wrote:
I wonder if the path to the image is a problem? @arfon<https://github.com/arfon> - can you help with this? (since we can't see the generate pdf log to see any error msgs)
@kmzzhang<https://github.com/kmzzhang> - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?
I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.
Also, can you confirm @kmzzhang<https://github.com/kmzzhang> that this is a joint submission with AAS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1647?email_source=notifications&email_token=AJSWHVHJCWIN3GVRXCQ7O2DQESO4XA5CNFSM4ILQH3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KPM5A#issuecomment-521467508>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJSWHVHUCSAOWZRTWIQNIGTQESO4XANCNFSM4ILQH3JQ>.
|
👍 thanks for confirming. / cc @crawfordsm |
@kmzzhang Please use Github instead of email for responding in the future since the responses from email is very verbose. Thank you. |
@whedon assign @shreyasbapat as reviewer |
OK, the reviewer is @shreyasbapat |
@whedon add @DanielLenz as reviewer |
OK, @DanielLenz is now a reviewer |
@whedon start review |
@whedon generate pdf |
|
@whedon start review |
OK, I've started the review over in #1651. Feel free to close this issue now! |
@shreyasbapat @DanielLenz Thank you! Look forward to your review in #1651! |
Submitting author: @kmzzhang (Keming Zhang)
Repository: https://github.com/profjsb/deepCR
Version: 0.1.5
Editor: @terrytangyuan
Reviewers: @shreyasbapat, @DanielLenz
Author instructions
Thanks for submitting your paper to JOSS @kmzzhang. Currently, there isn't an JOSS editor assigned to your paper.
@kmzzhang if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: