Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: hopit: An R Package for Analysis of Reporting Behavior Using Generalized Ordered Probit Models #1481

Closed
whedon opened this issue May 30, 2019 · 36 comments

Comments

@whedon
Copy link

whedon commented May 30, 2019

Submitting author: @MaciejDanko (Maciej J. Dańko)
Repository: https://github.com/MaciejDanko/hopit
Version: 0.9.2.9000
Editor: @alexhanna
Reviewers: @soodoku, @mkearney

Author instructions

Thanks for submitting your paper to JOSS @MaciejDanko. Currently, there isn't an JOSS editor assigned to your paper.

@MaciejDanko if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 30, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented May 30, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 30, 2019

PDF failed to compile for issue #1481 with the following error:

Error producing PDF.
! LaTeX Error: File `float.sty' not found.

Type X to quit or to proceed,
or enter new name. (Default extension: sty)

Enter file name:
! Emergency stop.
<read *>

l.253 ^^M

Looks like we failed to compile the PDF

@kyleniemeyer
Copy link

Hi @alexhanna, this submission looks up your alley. Do you have the bandwidth to edit this submission?

@kyleniemeyer
Copy link

Hi @MaciejDanko, our automated system is having some trouble compiling your paper—I think it is the (attempted) inclusion of the float package, and then using the LaTeX figure commands in the Markdown paper. Can you instead try to use Markdown figure commands?

@arfon, can you comment on whether this should be possible? I know we have been working on supporting fully LaTeX-based submissions, if that is necessary for what the author wants.

@arfon
Copy link
Member

arfon commented May 30, 2019

@arfon, can you comment on whether this should be possible? I know we have been working on supporting fully LaTeX-based submissions, if that is necessary for what the author wants.

If possible, we strongly prefer people to use standard Markdown syntax here for including figures.

e.g. Figures can be included like this: ![Example figure.](figure.png)

@MaciejDanko
Copy link

Thank you for your quick response,
paper.md is written in the standard Markdown syntax now

@alexhanna
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 31, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 31, 2019

@kyleniemeyer
Copy link

@MaciejDanko great, thanks! @alexhanna I'll leave this in your hands now.

@kyleniemeyer
Copy link

@whedon assign @alexhanna as editor

@whedon
Copy link
Author

whedon commented May 31, 2019

OK, the editor is @alexhanna

@MaciejDanko
Copy link

I checked the paper proof and found that there is a problem with figure 3 caption.
The md code looks OK, I don't know why there is a problem.

@MaciejDanko
Copy link

... I think this is Whedon's problem, I could generate the pdf without mistakes.
Anyway, I shortened the caption of the figure 3 and added additional blank lines
Could you check if it works now?

@arfon
Copy link
Member

arfon commented Jun 8, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 8, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 8, 2019

@arfon
Copy link
Member

arfon commented Jun 8, 2019

@MaciejDanko - you had a typo in your paper.md which I've fixed in MaciejDanko/hopit#5

@MaciejDanko
Copy link

I don't know why I didn't notice the typos.
Thank you very much!
paper.md is updated now.

@arfon
Copy link
Member

arfon commented Jun 8, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 8, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 8, 2019

@MaciejDanko
Copy link

Proof checked. No problems found. Thank you.

@MaciejDanko
Copy link

@alexhanna - I looked at the reviewers list. Here are my suggestions:

soodoku
Tgerke
benmarwick
lebebr01
mariacuellar
vincentarelbundock
mkearney

@alexhanna
Copy link

Thanks.

@soodoku
@tgerke
@benmarwick
@lebebr01
@mariacuellar
@vincentarelbundock
@mkearney

We need two reviewers for this submission. Would any of you be willing to review?

@soodoku
Copy link

soodoku commented Jun 16, 2019

Sure.

@vincentarelbundock
Copy link

I'm also happy to take a look, but I'll be travelling for work, so unlikely to get to this before about 3 weeks.

@mkearney
Copy link

I'd be willing to review as well.

@alexhanna
Copy link

I'll assign @soodoku and @mkearney based on availability, then. Thanks all.

@alexhanna
Copy link

@whedon assign @soodoku as reviewer

@whedon whedon assigned alexhanna and unassigned alexhanna Jun 17, 2019
@whedon
Copy link
Author

whedon commented Jun 17, 2019

OK, the reviewer is @soodoku

@alexhanna
Copy link

@whedon add @mkearney as reviewer

@whedon whedon assigned alexhanna and unassigned alexhanna Jun 17, 2019
@whedon
Copy link
Author

whedon commented Jun 17, 2019

OK, @mkearney is now a reviewer

@alexhanna
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Jun 17, 2019

OK, I've started the review over in #1508. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants