Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pyclustering #1195

Closed
whedon opened this issue Jan 22, 2019 · 26 comments
Closed

[PRE REVIEW]: pyclustering #1195

whedon opened this issue Jan 22, 2019 · 26 comments

Comments

@whedon
Copy link

whedon commented Jan 22, 2019

Submitting author: @annoviko (Andrei Novikov)
Repository: https://github.com/annoviko/pyclustering
Version: 0.8.2
Editor: @poulson
Reviewers: @adavidzh

Author instructions

Thanks for submitting your paper to JOSS @annoviko. The JOSS editor Pending, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@annoviko if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 22, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jan 22, 2019

Attempting PDF compilation. Reticulating splines etc...

@arfon
Copy link
Member

arfon commented Jan 22, 2019

👋 @poulson - would you be willing to edit this submission for JOSS?

@whedon
Copy link
Author

whedon commented Jan 22, 2019

PDF failed to compile for issue #1195 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 184 0 --:--:-- --:--:-- --:--:-- 185
sh: 0: getcwd() failed: No such file or directory
sh: 0: getcwd() failed: No such file or directory
sh: 0: getcwd() failed: No such file or directory
pandoc: 10.21105.joss.01195.pdf: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@arfon
Copy link
Member

arfon commented Jan 22, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 22, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jan 22, 2019

@annoviko
Copy link

annoviko commented Jan 23, 2019

Hello, @arfon,
I have checked the list and found out that adavidzh, dvysardana, pragyansmita are suitable persons for review in line with the description (C/C++, Python, Cluster Analysis, Data Mining).

The article devoted to 0.8.2 version that is on stable release branch '0.8.2.rel' (link: https://github.com/annoviko/pyclustering/tree/0.8.2.rel). DOI is already assigned for this release (link: https://zenodo.org/record/1491324#.XEgztVUzaUk) and it can be used by JOSS if it does not contradict the rules. Master branch already contains changes related to the new version of the library.

@arfon
Copy link
Member

arfon commented Jan 23, 2019

I have checked the list and found out that adavidzh, dvysardana, pragyansmita are suitable persons for review in line with the description (C/C++, Python, Cluster Analysis, Data Mining).

Thanks @annoviko. Before we decide upon reviewers, we need to have an editor assigned - this shouldn't take more than a week.

The article devoted to 0.8.2 version that is on stable release branch '0.8.2.rel' (link: https://github.com/annoviko/pyclustering/tree/0.8.2.rel). DOI is already assigned for this release (link: https://zenodo.org/record/1491324#.XEgztVUzaUk) and it can be used by JOSS if it does not contradict the rules. Master branch already contains changes related to the new version of the library.

Is the paper (#1195 (comment)) above not correct then? We can ask @whedon to compile a paper from a different branch in your repository.

Also, regarding the DOI & archive you already have - this might be OK, if your code is modified because of the review here we would ask you to make a new archive before publication.

@annoviko
Copy link

@arfon, thanks for the clarification. The paper is totally correct, no need to rebuild it, I have just provided some extra information about the repository.

@danielskatz
Copy link

👋 @arfon - is this ready to go to an editor in your opinion? If so, can you suggest one? If not, what else do you think is needed?

@arfon
Copy link
Member

arfon commented Jan 28, 2019

If so, can you suggest one?

Many of our editors are pretty loaded right now. Perhaps @poulson could take this one?

@danielskatz
Copy link

👋 @poulson - Are you able to edit this submission?

@danielskatz
Copy link

👋 @poulson - ping... Are you able to edit this submission?

@poulson
Copy link

poulson commented Feb 3, 2019

@arfon @danielskatz Yes, I would be happy to edit this submission and apologize, none of my pings had been going through. I promise I was not actively ignoring this!

@poulson
Copy link

poulson commented Feb 3, 2019

@lmcinnes Would you be able to review this submission?

@poulson
Copy link

poulson commented Feb 3, 2019

@adavidzh Would you be able to review this submission?

@adavidzh
Copy link

adavidzh commented Feb 4, 2019

@adavidzh Would you be able to review this submission?

I just looked through the different materials and can do.

@danielskatz
Copy link

danielskatz commented Feb 4, 2019

@whedon assign @poulson as editor

by the way @poulson - you can perform this command too...

@whedon
Copy link
Author

whedon commented Feb 4, 2019

OK, the editor is @poulson

@poulson
Copy link

poulson commented Feb 4, 2019

@whedon assign @adavidzh as reviewer

@whedon whedon assigned adavidzh and unassigned poulson Feb 4, 2019
@whedon
Copy link
Author

whedon commented Feb 4, 2019

OK, the reviewer is @adavidzh

@poulson
Copy link

poulson commented Feb 4, 2019

@whedon commands

@whedon
Copy link
Author

whedon commented Feb 4, 2019

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Ask Whedon to accept the paper and deposit with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

@poulson
Copy link

poulson commented Feb 4, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 4, 2019

OK, I've started the review over in #1230. Feel free to close this issue now!

@poulson poulson closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants