Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pyam: a Python Package for the Analysis and Visualization of Assessment Models #1092

Closed
whedon opened this issue Nov 20, 2018 · 29 comments

Comments

@whedon
Copy link

whedon commented Nov 20, 2018

Submitting author: @gidden (Matthew Gidden)
Repository: https://github.com/IAMconsortium/pyam
Version: v0.1.2
Editor: @lheagy
Reviewers: @jtmiclat, @Chilipp

Author instructions

Thanks for submitting your paper to JOSS @gidden. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@gidden if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 20, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @lheagy it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@lheagy) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Nov 20, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 20, 2018

PDF failed to compile for issue #1092 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1092/paper/paper.md): mapping values are not allowed in this context at line 5 column 18 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-b79e4e9c8e4d/lib/whedon.rb:68:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-b79e4e9c8e4d/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-b79e4e9c8e4d/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-b79e4e9c8e4d/bin/whedon:52:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-b79e4e9c8e4d/bin/whedon:113:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@arfon
Copy link
Member

arfon commented Nov 20, 2018

👋 @lheagy - the submitting author suggested you as the handling editor.

@arfon
Copy link
Member

arfon commented Nov 20, 2018

👋 @gidden: this PR fixes the YAML of your paper: IAMconsortium/pyam#144

@gidden
Copy link

gidden commented Nov 20, 2018

Thanks again @arfon, PR is merge. This is my first submission to JOSS, will @whedon automatically rerender pdfs upon updates to master or do we need to explicitly ask it to do so?

@arfon
Copy link
Member

arfon commented Nov 20, 2018

we need to explicitly ask it to do so?

You'll need to request another build. You can do this with @whedon generate pdf

@gidden
Copy link

gidden commented Nov 20, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 20, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 20, 2018

@gidden
Copy link

gidden commented Nov 20, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 20, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 20, 2018

@gidden
Copy link

gidden commented Nov 20, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 20, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 20, 2018

@lheagy
Copy link
Member

lheagy commented Nov 20, 2018

👋 Hi @arfon and @gidden: I am happy to be the editor on this. You might have to be a bit patient with me - I am in the middle of moving; please don't hesitate to ping me if you are waiting for a response from me. I will start looking for reviewers later today.

@lheagy
Copy link
Member

lheagy commented Nov 21, 2018

Hi @gidden: Thanks for your submission!

One quick think that I suggest is that you might consider including reference to "Climate science" in your title (the term "models" is very general, and from the title, it is not necessarily clear which domain of science the software is relevant to)

@lheagy
Copy link
Member

lheagy commented Nov 21, 2018

👋 Hi @Chilipp and @jtmiclat, would you be willing to review this submission for JOSS?

@jtmiclat
Copy link

Hello @lheagy, I am willing to review this but I am only able to start on weekend. Hope that is alright!

@lheagy
Copy link
Member

lheagy commented Nov 22, 2018

Excellent, thanks @jtmiclat! Yes, starting on the weekend is fine

@Chilipp
Copy link

Chilipp commented Nov 22, 2018

Hello @lheagy! Yes, I am willing to review it, too

@lheagy
Copy link
Member

lheagy commented Nov 22, 2018

Thanks @Chilipp!!

@lheagy
Copy link
Member

lheagy commented Nov 22, 2018

@whedon assign @jtmiclat as reviewer

@whedon
Copy link
Author

whedon commented Nov 22, 2018

OK, the reviewer is @jtmiclat

@lheagy
Copy link
Member

lheagy commented Nov 22, 2018

@whedon add @Chilipp as reviewer

@whedon
Copy link
Author

whedon commented Nov 22, 2018

OK, @Chilipp is now a reviewer

@lheagy
Copy link
Member

lheagy commented Nov 22, 2018

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 22, 2018

OK, I've started the review over in #1095. Feel free to close this issue now!

@lheagy lheagy closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants