Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect includePathExceptionsInClasspath also if no module-info.java is provided #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Respect includePathExceptionsInClasspath also if no module-info.java is provided #163

wants to merge 2 commits into from

Conversation

martinleim
Copy link

@martinleim martinleim commented Dec 30, 2022 •
edited
Loading

This PR fixes #62:

  • moves the addition of path exceptions to classpath outside of the block that only executes if the JavaFX app contains a module-info.java
  • fixes a wrong path in unit tests which caused the build to fail under Windows

@martinleim martinleim mentioned this pull request Dec 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can you tell how to convert custom image (build by javafx:jlink)to exe?
1 participant
@martinleim