Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS menu at launch #386

Closed
wants to merge 1 commit into from
Closed

Conversation

alblue
Copy link

@alblue alblue commented Jan 24, 2021

When a Java application launches, the menu is not immediately clickable. A
recent change in macOS broke the functionality used before, which calls
activateWithOptions outside of the applicationDidFinishLaunching delegate
call.

As per https://stackoverflow.com/questions/62739862 this can be fixed by
moving the activateWithOptions calls into the delegate's callback.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jfx pull/386/head:pull/386
$ git checkout pull/386

When a Java application launches, the menu is not immediately clickable. A
recent change in macOS broke the functionality used before, which calls
`activateWithOptions` outside of the `applicationDidFinishLaunching` delegate
call.

As per https://stackoverflow.com/questions/62739862 this can be fixed by
moving the `activateWithOptions` calls into the delegate's callback.
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@alblue
Copy link
Author

alblue commented Jan 24, 2021

NB I've tried to build/test this locally but wasn't successful. I'm also aware this may not be the appropriate way of fixing this for the JavaFX project. This is an alternate approach to pull #361 and based off the prior commit, though if this goes ahead I would expect that pull #361 changes are reverted, then this rebased on top of head. /cc @kevinrushforth

@alblue alblue closed this May 16, 2021
@kevinrushforth
Copy link
Member

I finally got a chance to try this, and it didn't work for me. If I locally revert the deactivation / reactivation changes from PR #361 and apply the proposed fix from this patch, the menu bar is back to being non-responsive until you switch away from the app and switch back. Given the the way JavaFX is launching the macOS application, it seems it isn't sufficient to move the activation to applicationDidFinishLaunching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants