Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331877: JFR: Remove JIInliner framework #19483

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented May 30, 2024

Could I have a review of a change that removes obsolete classes used for bytecode transformation of the JDK.

Testing: test/jdk/jdk/jfr + tier1

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331877: JFR: Remove JIInliner framework (Sub-task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19483/head:pull/19483
$ git checkout pull/19483

Update a local copy of the PR:
$ git checkout pull/19483
$ git pull https://git.openjdk.org/jdk.git pull/19483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19483

View PR using the GUI difftool:
$ git pr show -t 19483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19483.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@egahlin egahlin changed the title JFR: Remove JIInliner framework 8331877: JFR: Remove JIInliner framework May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331877: JFR: Remove JIInliner framework

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • a7864af: 8182774: Verify code in javap
  • 778ad00: 8308642: Unhelpful pattern switch error: illegal fall-through to a pattern
  • bb4aed9: 8332961: Parallel: Limit PSParallelCompact::verify_complete range
  • 95c8a69: 8332032: C2: Remove ExpandSubTypeCheckAtParseTime flag
  • ba323b5: 8333047: Remove arena-size-workaround in jvmtiUtils.cpp
  • 22ef827: 8320396: Class-File API ClassModel::verify should include checks from hotspot/share/classfile/classFileParser.cpp
  • 2ab8ab5: 8332858: References with escapes have broken positions after they are transformed
  • 1b7d59f: 8333303: Issues with DottedVersion class
  • e304a8a: 8333307: Don't suppress jpackage logging in tests when it is detecting packaging tools in the system
  • 3634a91: 8332751: Broken link in VirtualMachine.html
  • ... and 10 more: https://git.openjdk.org/jdk/compare/4acafb809c66589fbbfee9c9a4ba7820f848f0e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 30, 2024

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@egahlin egahlin marked this pull request as ready for review May 30, 2024 15:46
@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2024
@mlbridge
Copy link

mlbridge bot commented May 30, 2024

Webrevs

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2024
@egahlin
Copy link
Member Author

egahlin commented May 31, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2024

Going to push as commit 5abc029.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2024
@openjdk openjdk bot closed this May 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2024
@openjdk
Copy link

openjdk bot commented May 31, 2024

@egahlin Pushed as commit 5abc029.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants