feat: add a component to support rate limt control #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
|
not: but: example: Fixes #20 |
not: but: example: Fixes #20 |
|
not: but: |
|
Suggest to rename filename |
IRONICBo
reviewed
Jun 28, 2023
| } | ||
| return func(c *gin.Context) { | ||
| if !tb.Allow() { | ||
| c.String(503, "Too many request") |
There was a problem hiding this comment.
use constant in http or define a constant in OpenKF/server/internal/common/code.go.
PolarishT
changed the title
|
@AllianceTing Please check CI report https://github.com/OpenIMSDK/OpenKF/actions/runs/5418577637/jobs/9850806240?pr=29 |
PolarishT
added
good first issue
Signed-off-by: SgitBusity <[email protected]>
transfer to I18N
Signed-off-by: SgitBusity <[email protected]>
Signed-off-by: SgitBusity <[email protected]>
fix return formating Signed-off-by: SgitBusity <[email protected]>
cubxxw
suggested changes
Jul 2, 2023
|
|
||
| // allow frequency | ||
| func (tb *frequencyControlByTokenBucket) Allow() bool { | ||
| tb.mtx.Lock() |
|
|
||
| // define rate limit struct | ||
| type frequencyControlByTokenBucket struct { | ||
| refreshRate float64 // 令牌的刷新速率 |
| mtx sync.Mutex // 互斥锁 | ||
| } | ||
|
|
||
| // allow frequency |
| } | ||
| return func(c *gin.Context) { | ||
| if !tb.Allow() { | ||
| c.String(503, "Too many request") |
There was a problem hiding this comment.
return: gin.Context the mechanism of error processing
| } | ||
|
|
||
| // registried a middle ware | ||
| func LimitHandler(maxConn int, refreshRate float64) gin.HandlerFunc { |
| // define rate limit struct | ||
| type frequencyControlByTokenBucket struct { | ||
| refreshRate float64 // 令牌的刷新速率 | ||
| capacity int64 // 桶的容量 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 What this PR does / why we need it:
🅰 Which issue(s) this PR fixes:
Fixes #20
📝 Special notes for your reviewer:
🎯 Describe how to verify it
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: