Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add some frontend specifications #18

Closed
2 tasks done
MC-kanon opened this issue Jun 27, 2023 · 2 comments · Fixed by #30
Closed
2 tasks done

Feature: add some frontend specifications #18

MC-kanon opened this issue Jun 27, 2023 · 2 comments · Fixed by #30
Assignees
@MC-kanon
Labels
enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v0.1

Comments

@MC-kanon
Copy link
Collaborator

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the OpenIMSDK Slack and got positive feedback

Is this feature request related to a problem?

None

Problem Description

Solution Description

The current frontend project is not sufficiently standardised and there is no uniformity in the code submitted by fe members

Benefits

Improved code readability and maintainability

Potential Drawbacks

No response

Additional Information

No response
@MC-kanon MC-kanon self-assigned this Jun 27, 2023
@MC-kanon MC-kanon added the enhancement New feature or request label Jun 27, 2023
@MC-kanon MC-kanon changed the title Feature: add some frontend dependencies Feature: add some frontend specifications Jun 27, 2023
@cubxxw cubxxw moved this to In progress in openim-powerful Jun 27, 2023
@cubxxw cubxxw added this to the openkf-v1.0.0 milestone Jun 27, 2023
@PolarishT
Copy link
Contributor

attempt to use eslint+ lintstaged + commintlint + husky+ premitter to standardise members' code
submitted

@kubbot
Copy link
Contributor

kubbot commented Jun 27, 2023

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

attempt to use eslint lint staged + commitlint + husky premitter to standardise members' code
submitted

@cubxxw cubxxw added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 27, 2023
@cubxxw cubxxw added this to OpenKF Jun 28, 2023
@cubxxw cubxxw moved this to 🏗 In progress in OpenKF Jun 28, 2023
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 28, 2023
feat: add frontend specifications (openimsdk#18)
ca3c28d
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 28, 2023
feat: add frontend specifications(openimsdk#18)
b3972d4
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 28, 2023
feat: add prettier and eslint (openimsdk#18)
927ddfa
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 28, 2023
feat: add prettier and eslint(openimsdk#18)
1cdb009
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 28, 2023
feat: add prettier and eslint (openimsdk#18)
01a5479
@MC-kanon MC-kanon mentioned this issue Jun 28, 2023
Merged
@cubxxw cubxxw linked a pull request Jun 28, 2023 that will close this issue
feat: add prettier and eslint (#18) #30
Merged
MC-kanon pushed a commit to MC-kanon/OpenKF that referenced this issue Jun 29, 2023
feat: add prettier and eslint 2 (openimsdk#18)
cbdf28a
cubxxw added a commit that referenced this issue Jun 29, 2023
@MC-kanon @cubxxw
feat: add prettier and eslint (#18) (#30)
d2e1ed4 
Co-authored-by: wangyu116 <[email protected]>
Co-authored-by: Xinwei Xiong <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in OpenKF Jun 29, 2023
@cubxxw cubxxw moved this from In progress to Done in openim-powerful Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MC-kanon MC-kanon

Labels
enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
OpenKF
Status: ✅ Done
openim-powerful
Archived in project
Milestone
v0.1
Development

Successfully merging a pull request may close this issue.

feat: add prettier and eslint (#18) MC-kanon/OpenKF
4 participants
@PolarishT @MC-kanon @cubxxw @kubbot