Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comments #2183

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

coderwander
Copy link
Contributor

@coderwander coderwander commented Apr 16, 2024


🔍 What type of PR is this?

fix some typos in comments

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@kubbot
Copy link
Contributor

kubbot commented Apr 16, 2024

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@coderwander
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@cubxxw cubxxw enabled auto-merge April 16, 2024 05:42
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.63%. Comparing base (0b2df42) to head (381fd1b).
Report is 74 commits behind head on main.

❗ Current head 381fd1b differs from pull request most recent head 6a721f2. Consider uploading reports for the commit 6a721f2 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2183   +/-   ##
=====================================
  Coverage   4.63%   4.63%           
=====================================
  Files         28      28           
  Lines       1814    1813    -1     
=====================================
  Hits          84      84           
+ Misses      1720    1719    -1     
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderwander
Copy link
Contributor Author

Anything need I to do?

skiffer-git
skiffer-git previously approved these changes Apr 28, 2024
@skiffer-git
Copy link
Member

Conflicting files
config/templates/env.template

FGadvancer
FGadvancer previously approved these changes May 21, 2024
@skiffer-git
Copy link
Member

/recheck

@kubbot
Copy link
Contributor

kubbot commented Jul 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


/recheck

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2024
@skiffer-git skiffer-git merged commit caef9a1 into openimsdk:main Jul 26, 2024
1 check passed
@kubbot kubbot added this to the v3.6 milestone Jul 26, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants