Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modifying user information notifications to join groups and group avatar issues #1147

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: modifying user information notifications to join groups and group avatar issues #1147

merged 2 commits into from
Sep 28, 2023

Conversation

withchao
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1146

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2023
@kubbot
Copy link
Contributor

kubbot commented Sep 28, 2023 •
edited
Loading

CLA Assistant Lite bot 🤖 All Contributors have signed the open-im-server CLA.
The signed information is recorded 🤖here

@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim September 28, 2023 09:57 — with GitHub Actions Inactive
@withchao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Sep 28, 2023
@openimbot
@withchao has signed the CLA in openimsdk/open-im-server#1147
c8691b6
@withchao withchao added this pull request to the merge queue Sep 28, 2023
Merged via the queue into openimsdk:main with commit eb749af Sep 28, 2023
18 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Sep 28, 2023
@github-actions github-actions bot added this to the v3.1 milestone Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git skiffer-git approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Bug: modifying user information notifications to join groups and group avatar issues
5 participants
@withchao @kubbot @FGadvancer @skiffer-git @cubxxw