Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-80: Fixed LFI issue with report generating. #145

Merged
merged 2 commits into from
Feb 24, 2022
Merged

OS-80: Fixed LFI issue with report generating. #145

merged 2 commits into from
Feb 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2022

https://openimis.atlassian.net/browse/OS-80

Changes:

  • Functions gets path for reports from settings file
  • Functions sanitizes input by getting full path (no "example....")
  • Compares requested filepath with that in settings - if they are not the same no file is given to user.

@ghost ghost requested review from dragos-dobre and removed request for dragos-dobre February 15, 2022 14:36
@ghost ghost marked this pull request as draft February 15, 2022 14:43
@sniedzielski sniedzielski changed the base branch from main to feature/OS-82 February 15, 2022 14:49
@ghost ghost changed the title Feature/os 80 OS-80: Fixed LFI issue with report generating. Feb 15, 2022
@ghost ghost requested a review from dragos-dobre February 15, 2022 14:59
@ghost ghost marked this pull request as ready for review February 15, 2022 15:00
@dragos-dobre dragos-dobre merged commit 59085b7 into feature/OS-82 Feb 24, 2022
@hirensoni913 hirensoni913 deleted the feature/OS-80 branch October 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragos-dobre @wzgliniecki