-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-1903: Fixed PH display in PolicyHoldeerUsers List #91
Conversation
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@dborowiecki is the merge to bugfix/OP-1876 correct? |
withLabel={false} | ||
readOnly | ||
/> | ||
!!policyHolderUser.policyHolder ? `${policyHolderUser.policyHolder.code} - ${policyHolderUser.policyHolder.tradeName}` : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just take the policyholder projection instead of the creating one from scratch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delcroip I'm not sure how to change this, should we add another field on the PolicyHolderGQL type instead of building the string in the items formatter directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could create one like this (Ideally the picker projection should include the "to be created" display projection)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is that one have the change the projection in a single file then it will be change everywhere
@dragos-dobre Yes, I've created 2 separate PRs, if this one would be merged first then bugfix/OP-1876 base branch would change to develop. |
TICKET: https://openimis.atlassian.net/browse/OP-1903