Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1903: Fixed PH display in PolicyHoldeerUsers List #91

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dborowiecki
Copy link
Contributor

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dragos-dobre
Copy link
Member

@dborowiecki is the merge to bugfix/OP-1876 correct?

Base automatically changed from bugfix/OP-1876 to develop October 2, 2024 13:22
withLabel={false}
readOnly
/>
!!policyHolderUser.policyHolder ? `${policyHolderUser.policyHolder.code} - ${policyHolderUser.policyHolder.tradeName}` : ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just take the policyholder projection instead of the creating one from scratch ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delcroip I'm not sure how to change this, should we add another field on the PolicyHolderGQL type instead of building the string in the items formatter directly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could create one like this (Ideally the picker projection should include the "to be created" display projection)

https://github.com/openimis/openimis-fe-policyholder_js/blob/2c9260c71cdd4dc85457f8ae7e28ba7b5f1697d1/src/actions.js#L32C14-L32C44

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is that one have the change the projection in a single file then it will be change everywhere

@dborowiecki
Copy link
Contributor Author

@dborowiecki is the merge to bugfix/OP-1876 correct?

@dragos-dobre Yes, I've created 2 separate PRs, if this one would be merged first then bugfix/OP-1876 base branch would change to develop.

@delcroip delcroip changed the base branch from develop to release/24.10 October 24, 2024 13:43
@delcroip delcroip merged commit 1f5efb6 into release/24.10 Oct 24, 2024
1 of 2 checks passed
@delcroip delcroip deleted the bugfix/OP-1903 branch October 24, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants