Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONI-168: make a notice message larger #18

Merged
merged 2 commits into from
Oct 10, 2023
Merged

ONI-168: make a notice message larger #18

merged 2 commits into from
Oct 10, 2023

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Oct 9, 2023 •
edited by jira bot
Loading

ONI-168

Changes:

  • Make a notice message larger.
  • If user has no HF assigned, display appropriate information instead of HF status and contract details.

@olewandowski1 olewandowski1 requested review from sniedzielski and a user October 9, 2023 09:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@olewandowski1 olewandowski1 marked this pull request as ready for review October 10, 2023 07:04
@ghost
Copy link

ghost commented Oct 10, 2023

LGTM

@dragos-dobre dragos-dobre merged commit 059d6a8 into develop Oct 10, 2023
3 checks passed
@dragos-dobre dragos-dobre deleted the feature/ONI-168 branch October 10, 2023 09:43
dragos-dobre added a commit that referenced this pull request Oct 18, 2023
@dragos-dobre @olewandowski1 @jdolkowski
MERGING RELEASE branches (#17)
a019c54 
* ONI-106: User HF status information. (#14)

* ONI-106: User HF status information.

* ONI-106: HF status code review fixes.

* ONI-106: HF status fixed if no HF assigned. (#16)

* ONI-168: make a notice message larger (#18)

* ONI-168: make a notice message larger

* ONI-168: if user has no hf, show info about that instead of contract details

* add-sonar-ci: add ci file (#19)

Co-authored-by: Jan <[email protected]>

---------

Co-authored-by: wzglinieckisoldevelo <[email protected]>
Co-authored-by: olewandowski1 <[email protected]>
Co-authored-by: Jan <[email protected]>
Co-authored-by: Jan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski approved these changes

@dragos-dobre dragos-dobre dragos-dobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olewandowski1 @dragos-dobre @sniedzielski