This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Rescue from Yadis::XRI::XRIHTTPError on discovery #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is explicitly thrown on any fetch errors by Yadis::XRI::ProxyResolve#query (including for bad URIs, network issues, invalid responses, ...)
|
A note regarding the test failures, all of which are unrelated to this pull request
|
|
Hi @meineerde |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 18, 2019
Update ruby-ruby-openid package to version 2.9.2. ## 2.9.2 * Perform all checks before verifying endpoints. [#126](openid/ruby-openid#126) ## 2.9.1 * Updated CHANGELOG.md ## 2.9.0 * Remove deprecated `autorequire` from gemspec. [#123](openid/ruby-openid#123) * Rescue from `Yadis::XRI::XRIHTTPError` on discovery. [#106](openid/ruby-openid#106) * Avoid SSRF for claimed_id request. [#121](openid/ruby-openid#121) * Updated documentation. [#115](openid/ruby-openid#115), [#116](openid/ruby-openid#116), [#117](openid/ruby-openid#117), [#118](openid/ruby-openid#118) * Reduce warnings output in test runs. [#119](openid/ruby-openid#119) * Drop deprecated option from gemspec. [#120](openid/ruby-openid#120) * Remove circular require. [#113](openid/ruby-openid#113) * Updated Travis CI config with Ruby 2.6 [#114](openid/ruby-openid#114) * Simplify Bundler require; remove need for extra `:require`. [#112](openid/ruby-openid#112) ## 2.8.0 * Fix `admin/mkassoc` script. See openid/ruby-openid#103 * Allow specifying timeout for `OpenID::StandardFetcher` in environment variables. See openid/ruby-openid#109 * Fixed some documentation. See openid/ruby-openid#111 * Fixed example server. See openid/ruby-openid#91 * Fixed tests. See openid/ruby-openid#86 * Misc. changes to the CI setup. See - openid/ruby-openid#110 - openid/ruby-openid#108 - openid/ruby-openid#107
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is explicitly thrown on any fetch errors by
Yadis::XRI::ProxyResolve#query(including for bad URIs, network issues, invalid responses, ...) Since this error is not rescued anywhere today, it bubbles up beyondOpenID::Consumer.beginwhen called with e.g. an invalid URL like"(this is not a URL)"(including the parenthesis).I'm not sure how to properly test this with the different mock-fetchers. For someone more accustomed with the tests, this might be easier :)