Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OID4VP profile for the W3C Digital Credentials API #155

Merged
merged 44 commits into from
Jul 9, 2024
Merged

OID4VP profile for the W3C Digital Credentials API #155

merged 44 commits into from
Jul 9, 2024

Commits on Mar 29, 2024

  1. added sequence diagram for request uri flow

    @tlodderstedt
    tlodderstedt committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    fb86e55 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. first draft oid4vp profile for dc api

    @tlodderstedt
    tlodderstedt committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    e6c090a View commit details
    Browse the repository at this point in the history

  2. fixed formatting

    @tlodderstedt
    tlodderstedt committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    4c11ded View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. fixed typo

    @tlodderstedt
    tlodderstedt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    95a4c0f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. changed request to object

    @tlodderstedt
    tlodderstedt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f5ba49f View commit details
    Browse the repository at this point in the history

  2. updated PR based on IIW discussion on 04-18

    @tlodderstedt
    tlodderstedt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    278c475 View commit details
    Browse the repository at this point in the history

  3. modified JS code examples

    @tlodderstedt
    tlodderstedt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    24b0573 View commit details
    Browse the repository at this point in the history

  4. Update openid-4-verifiable-presentations-1_0.md 

    Co-authored-by: Brian Campbell <[email protected]>
    @tlodderstedt @bc-pi
    tlodderstedt and bc-pi authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    25702e0 View commit details
    Browse the repository at this point in the history

  5. reworked examples and added signed request sequence diagram

    @tlodderstedt
    tlodderstedt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    144f78b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'browser_api' of https://github.com/openid/OpenID4VP int… 

    …o browser_api
    @tlodderstedt
    tlodderstedt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0cfeb87 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Apply editorial suggestions from code review 

    Co-authored-by: Christian Bormann <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
Co-authored-by: Daniel Fett <[email protected]>
    @Sakurann @c2bo
    @bc-pi @danielfett
    4 people authored May 6, 2024
    Configuration menu
    Copy the full SHA
    baf35c9 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. resolve merge conflict

    Kristina Yasuda authored and Kristina Yasuda committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4a9f607 View commit details
    Browse the repository at this point in the history

  2. Apply text improvement suggestions from code review 

    Co-authored-by: Tim Cappalli <[email protected]>
Co-authored-by: Christian Bormann <[email protected]>
    @Sakurann @timcappalli @c2bo
    3 people authored May 28, 2024
    Configuration menu
    Copy the full SHA
    96bf495 View commit details
    Browse the repository at this point in the history

  3. response is always json

    @Sakurann
    Sakurann authored May 28, 2024
    Configuration menu
    Copy the full SHA
    8d8d9dc View commit details
    Browse the repository at this point in the history

  4. how the wallet recieves origin info is out of scope of this profile

    @Sakurann
    Sakurann authored May 28, 2024
    Configuration menu
    Copy the full SHA
    cb18fc2 View commit details
    Browse the repository at this point in the history

  5. clarify there are two types of allowed request parameters

    @Sakurann
    Sakurann authored May 28, 2024
    Configuration menu
    Copy the full SHA
    ec2bb01 View commit details
    Browse the repository at this point in the history

  6. merge remote

    Kristina Yasuda authored and Kristina Yasuda committed May 28, 2024
    Configuration menu
    Copy the full SHA
    40c9d11 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. reference example file from the text

    Kristina Yasuda authored and Kristina Yasuda committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a264071 View commit details
    Browse the repository at this point in the history

  2. remove a redundant example and extend one of the examples.

    Kristina Yasuda authored and Kristina Yasuda committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c85f012 View commit details
    Browse the repository at this point in the history

  3. move signed and unsigned request sections and clarify JARM and respon… 

    …se_mode
    Kristina Yasuda authored and Kristina Yasuda committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    242fa62 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Apply suggestions from Sam's code review 

    Co-authored-by: Sam Goto <[email protected]>
    @Sakurann @samuelgoto
    Sakurann and samuelgoto authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2907e60 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. merge main

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f5f199c View commit details
    Browse the repository at this point in the history

  2. add a history entry

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4122a95 View commit details
    Browse the repository at this point in the history

  3. change to the request member of the API and use openid4vp instead of … 

    …oid4vp
    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6d58f69 View commit details
    Browse the repository at this point in the history

  4. fix indentation

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    53fb19a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from joseph's code review 

    Co-authored-by: Joseph Heenan <[email protected]>
    @Sakurann @jogu
    Sakurann and jogu authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    72f75c4 View commit details
    Browse the repository at this point in the history

  6. fix request and response examples

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d89cd9c View commit details
    Browse the repository at this point in the history

  7. move examples and clarify client_id is not allowed over the unsigned … 

    …request
    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9e583fd View commit details
    Browse the repository at this point in the history

  8. JSON -> JS object

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fbf9fe9 View commit details
    Browse the repository at this point in the history

  9. update examples

    Kristina Yasuda authored and Kristina Yasuda committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ec75040 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review

    @Sakurann
    Sakurann authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    a15c41c View commit details
    Browse the repository at this point in the history

  11. dropping client_id and client_id_scheme with signed requests

    @Sakurann
    Sakurann authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    35af423 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from joseph's code review 

    Co-authored-by: Joseph Heenan <[email protected]>
    @Sakurann @jogu
    Sakurann and jogu authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    81bfbb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'main' into browser_api

    @Sakurann
    Sakurann authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    31ef192 View commit details
    Browse the repository at this point in the history

  2. Apply editorial suggestions from code review 

    Co-authored-by: Christian Bormann <[email protected]>
    @Sakurann @c2bo
    Sakurann and c2bo authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    af88822 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Apply editorial suggestions from code review 

    Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Tim Cappalli <[email protected]>
Co-authored-by: Oliver Terbu <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
    @Sakurann @peppelinux
    @timcappalli @awoie @bc-pi
    5 people authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    772f537 View commit details
    Browse the repository at this point in the history

  2. more editorial. combining suggestions of multiple reviewers 

    Co-authored-by: Oliver Terbu <[email protected]>
    @Sakurann @awoie
    Sakurann and awoie authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    792010e View commit details
    Browse the repository at this point in the history

  3. remove a confusing expected_origins requirements

    @Sakurann
    Sakurann authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9a160de View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Apply editorial suggestions from code review 

    Co-authored-by: David Chadwick <[email protected]>
    @Sakurann @David-Chadwick
    Sakurann and David-Chadwick authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    084f112 View commit details
    Browse the repository at this point in the history

  2. Apply editorial suggestion from code review

    @Sakurann
    Sakurann authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ffe96e5 View commit details
    Browse the repository at this point in the history

  3. change urn:openid.net:oid4vp to openid4vp 

    Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Sam Goto <[email protected]>
    @Sakurann @marcoscaceres @samuelgoto
    3 people authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cf6aa75 View commit details
    Browse the repository at this point in the history

  4. removing "MUST contain a valid" openid4vp request 

    Co-authored-by: Joseph Heenan <[email protected]>
    @Sakurann @jogu
    Sakurann and jogu authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    13da249 View commit details
    Browse the repository at this point in the history

  5. changing the error handling

    @Sakurann
    Sakurann authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4dd3893 View commit details
    Browse the repository at this point in the history

  6. in the examples change urn:openid.net:oid4vp to openid4vp and add res… 

    …ponse_mode

Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Christian Bormann <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
    @Sakurann @marcoscaceres
    @c2bo @bc-pi
    4 people authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e42c69b View commit details
    Browse the repository at this point in the history