Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser API example unsigned request appears not to be conformant with the spec text #244

Closed
jogu opened this issue Sep 3, 2024 · 2 comments · Fixed by #250
Closed

Browser API example unsigned request appears not to be conformant with the spec text #244

jogu opened this issue Sep 3, 2024 · 2 comments · Fixed by #250

Comments

@jogu
Copy link
Collaborator

jogu commented Sep 3, 2024

At https://openid.net/specs/openid-4-verifiable-presentations-1_0-21.html#appendix-A.2 the example does not include response_mode but the text a few paragraphs below this example appears to make omissions of response_mode illegal:

The value of the response_mode parameter MUST be w3c_dc_api when the response is neither signed nor encrypted and w3c_dc_api.jwt when the response is signed and/or encrypted as defined in Section 6.3.

I have a slight feeling that the intention was that response_mode could be omitted and would effectively default to w3c_dc_api for requests received via the API but I can't fully remember.

@bc-pi
Copy link
Member

bc-pi commented Sep 6, 2024

I'm about 99% sure that's just a mistaken omission in that example that was missed somewhere in the course of the 200 some comments and 40 some commits to #155.

@bc-pi
Copy link
Member

bc-pi commented Sep 6, 2024

#250 adds it to the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants