Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove c_nonce_expires_in from nonce response #419

Merged
merged 3 commits into from
Dec 3, 2024
Merged

remove c_nonce_expires_in from nonce response #419

merged 3 commits into from
Dec 3, 2024

Conversation

tplooker
Copy link
Contributor

Resolves #394

@tplooker tplooker force-pushed the tl/c-nonce-expires-removal branch from 8b33213 to ea153bc Compare November 28, 2024 23:11
@tplooker tplooker requested review from babisRoutis, bc-pi, peppelinux, jogu and Sakurann and removed request for bc-pi November 28, 2024 23:11
@tplooker
Copy link
Contributor Author

Thanks all, I have updated the PR to remove this sentence, I also added one sentence to the c_nonce definition to make it clear the expectations around its unpredictability and uniqueness across responses from the nonce endpoint.

bc-pi
bc-pi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement that this "value MUST be unpredictable" is a bit odd to me but who am I to judge?

@tlodderstedt tlodderstedt merged commit a1a3db9 into main Dec 3, 2024
2 checks passed
@Sakurann Sakurann mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babisRoutis babisRoutis babisRoutis approved these changes

@bc-pi bc-pi bc-pi approved these changes

@awoie awoie awoie approved these changes

@paulbastian paulbastian paulbastian approved these changes

@leecam leecam leecam approved these changes

@c2bo c2bo c2bo approved these changes

@nemqe nemqe nemqe approved these changes

@jogu jogu jogu approved these changes

@peppelinux peppelinux Awaiting requested review from peppelinux

@Sakurann Sakurann Awaiting requested review from Sakurann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing the c_nonce_expires_in parameter