-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authorization token Bearer prefix spelling in examples #372
Conversation
"BEARER" is perfectly legal https://www.rfc-editor.org/rfc/rfc9110.html#name-authentication-scheme |
According to RFC9110 the authentication scheme is indeed case-insensitive contrary to how it is defined in RFC6750, so this issue can be closed. Would it still be good to unify the scheme spelling in the examples? Edit: additionally I did not know that ABNF literal text strings are case-insensitive: https://www.rfc-editor.org/rfc/rfc5234#page-5. Hence the "Bearer" in RFC6750 can be spelled "BEARER" or "BeArEr", etc. |
@srosenda thanks a lot for doing the PR! Do you have contribution agreement/IPR signed with OIDF DCP WG? |
@srosenda you can always sign an individual contribution agreement. that would unblock us in a minute. |
17a29ab
to
e0cde14
Compare
Rebased with main and amended the commit to unify the spelling also in the Token Response's |
Although the authorization scheme is case-insensitive, all the examples in the referred specifications RFC 6749 (and RFC 6750 referred by it) use the spelling "Bearer", which is also the spelling in the IANA HTTP Authentication Scheme Registry. Unified spelling reduces confusion and possible mistakes in implementations that have missed the case- insensitivity of the authentication scheme.
e0cde14
to
03d4204
Compare
Fixed terminology to refer to authorization scheme in the commit message and signed the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best I remember the use of "BEARER" was intentional to demonstrate to readers exactly the point that authentication scheme names are case-insensitive but maybe I'm not remembering correctly and maybe no one cares anymore or ever.
Editorial, 4 approvals, open a while - merging! Thanks @srosenda ! |
the prefix should be spelled exactly as "Bearer", see RFC 6750, section 2.1. Authorization Request Header Field https://datatracker.ietf.org/doc/html/rfc6750#section-2.1.
Fixes #371.