Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of 'integer' #100

Closed
jogu opened this issue Nov 6, 2023 · 3 comments · Fixed by #110
Closed

Use of 'integer' #100

jogu opened this issue Nov 6, 2023 · 3 comments · Fixed by #110
Assignees
@jogu
Labels
clarification ready-for-PR

Comments

@jogu
Copy link
Contributor

jogu commented Nov 6, 2023

Some fields are defined as 'Integer', e.g.:

c_nonce_expires_in: OPTIONAL. Integer denoting the lifetime in seconds of the c_nonce.

I'm not sure what this really means (is it invalid to send 60.0?) and what it's implications for interoperability/conformance testing are.

I'd suggest changing to 'number'.
@Sakurann
Copy link
Collaborator

Sakurann commented Nov 9, 2023

is this somewhat related to issue #90?

@jogu
Copy link
Contributor Author

jogu commented Nov 9, 2023

@Sakurann probably not directly. That one is about dates, this one is about time intervals.

@jogu
Copy link
Contributor Author

jogu commented Nov 9, 2023

(This one is trivial, it could probably be considered editorial. I might even do a PR for it...)

jogu added a commit that referenced this issue Nov 10, 2023
@jogu
Change 'Integer' to 'Number'
dd62e9c 
As this is just in a JSON response restricting it to integer doesn't really
make any sense, it's can just be a number.

closes #100
@jogu jogu mentioned this issue Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jogu jogu

Labels
clarification ready-for-PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change 'Integer' to 'Number' openid/OpenID4VCI
2 participants
@jogu @Sakurann