Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of LEC/SEC scripts #929

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

MarioOpenHWGroup
Copy link
Contributor

  • LEC script refactor
  • SEC process always supported using Siemens SLEC App

@Silabs-ArjanB Silabs-ArjanB removed their request for review January 3, 2024 14:23
Copy link

@pascalgouedo pascalgouedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add those slec scripts to do the same than lec, meaning v1 versus v2 with v1 parameters setting?
Because as of today as the top level is cv32e40p_core and not cv32e40p_top and so it is excluding FPU.
We could extend the methodology for the future to be able to check v2 with v2+++ by moving top_module to cv32e40p_top.
I have done that for lint so I can lint v1 and all configurations of v2...
In fact to deal with configurability, I added a new top module (cv32e40p_wrapper which instantiates cv32e40p_top) which imports a config package which is selected by shell script depending of selected configuration.

scripts/slec/cadence/lec.tcl Outdated Show resolved Hide resolved
scripts/slec/siemens/Makefile Outdated Show resolved Hide resolved
@MarioOpenHWGroup
Copy link
Contributor Author

I have also added the Cadence SEC script using JasperGold, if you can review the PR again :)

@pascalgouedo pascalgouedo added Type:Enhancement For feature requests and enhancements Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) labels Feb 28, 2024
@pascalgouedo pascalgouedo merged commit c5bd3bd into openhwgroup:dev Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Tool-and-build For issues in the tool and build flow (e.g. Makefile, FuseSoc, etc.) Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants