Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVFI - Improving mstatsu_fs reporting and fcsr reporting #892

Merged
merged 4 commits into from
Oct 13, 2023
Merged

RVFI - Improving mstatsu_fs reporting and fcsr reporting #892

merged 4 commits into from
Oct 13, 2023

Conversation

YoannPruvost
Copy link
Contributor

This PR corrects two points I previously overlooked

  • moved the mstatus_fs reporting trigger for mstatus_we to mstatus_fs_we on APU instructions
  • remove the fcsr_we when we have frm_we or fflags_we and use the already in place mechanism when populating rvfi signals to handle the multi csr update

@YoannPruvost YoannPruvost added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Oct 13, 2023
@davideschiavone davideschiavone merged commit 3023e88 into openhwgroup:dev Oct 13, 2023
1 check passed
@YoannPruvost YoannPruvost deleted the dev_csr_and_fpu branch November 23, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideschiavone davideschiavone davideschiavone approved these changes

Assignees
No one assigned
Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoannPruvost @davideschiavone