mstatus fs addition & bug corrections #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgouedo
added
the
Component:RTL
davideschiavone
requested changes
Apr 24, 2023
bhv/cv32e40p_tb_wrapper.sv
Outdated
| @@ -400,7 +400,7 @@ module cv32e40p_tb_wrapper | |||
| .FPU (FPU), | |||
| .FPU_ADDMUL_LAT (FPU_ADDMUL_LAT), | |||
| .FPU_OTHERS_LAT (FPU_OTHERS_LAT), | |||
| .PULP_ZFINX (PULP_ZFINX), | |||
| .ZFINX (PULP_ZFINX), | |||
There was a problem hiding this comment.
can we call the toplevel parameter ZFINX as well?
There was a problem hiding this comment.
I wanted RTL to be compliant with present core-v-verif TB.
I am going to align all bhv and core-v-verif files to ZFINX once Yoann has submitted a final core-v-verif PR with full FPU & Zfinx support aligned with #799.
There was a problem hiding this comment.
Done with commit below (after verible)
added 11 commits
April 24, 2023 15:20
Added MSTATUS.FS and SD and all their control. Added fs_off_o for instructions decoder to generate illegal instructions when FS is OFF. Signed-off-by: Pascal Gouedo <[email protected]>
…tructions. Signed-off-by: Pascal Gouedo <[email protected]>
Issue openhwgroup#725 correction: Illegal exception for FMV/FLW/FSW when ZFINX. Updated MISA value and make MSTATUS.FS/SD ZFINX dependent. Signed-off-by: Pascal Gouedo <[email protected]>
Removed PULP_XPULP, PULP_CLUSTER, FPU, PULP_ZFINX assertions. Signed-off-by: Pascal Gouedo <[email protected]>
…ons following CSRW to FRM/FCSR. Signed-off-by: Pascal Gouedo <[email protected]>
…tid and privlv. Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
… cell. Updated all files from wrapper to top instantiation. Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
pascalgouedo
force-pushed
the
dev_dd_pgo_mstatus_fs-bug_corrections
branch
from
8a57f99 to
c90bb28
Compare
added 4 commits
May 2, 2023 15:06
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
…tools (LEC equivalent). Signed-off-by: Pascal Gouedo <[email protected]>
davideschiavone
approved these changes
May 10, 2023
davideschiavone
approved these changes
May 10, 2023
davideschiavone
approved these changes
May 10, 2023
This was referenced Oct 9, 2023
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #170 correction: Adding MSTATUS.FS/SD
Issue #724 correction: Illegal exception for unknown F instructions.
Move from PULP_ZFINX to ratified v1.0 ZFINX.
Issue #725 correction: Illegal exception for FMV/FLW/FSW when ZFINX.
Updated MISA value and make MSTATUS.FS/SD ZFINX dependent.
Move PULP_ZFINX parameter to ZFINX in all RTL files.
Removed PULP_XPULP, PULP_CLUSTER, FPU, PULP_ZFINX assertions.
Issue #174 and #169 correction: Flush instructions following CSRW to FRM/FCSR.
Issue #741 correction: Illegal exception when CSRW to uhartid and privlv.
Renamed cv32e40p_wrapper to cv32e40p_top and updated all files from wrapper to top instantiation.
Added in cv32e40p_top a clock gating cell for FPU.
Updates to allow MSTATUS.FS and SD comparison with Imperas ISS.
Moved PULP_XPULP to COREV_PULP and PULP_CLUSTER to COREV_CLUSTER.