Docs corrections and clarifications #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 7, 2022 16:53
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
…quality by equivalent to. Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
Closed
pascalgouedo
added
the
Component:Doc
added 2 commits
September 9, 2022 12:03
Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
davideschiavone
requested changes
Sep 10, 2022
| @@ -586,10 +586,10 @@ General ALU Operations | |||
| +=================+=========================+========================================================================+ | |||
| | **cv.abs** | **rD, rs1** | rD = rs1 < 0 ? –rs1 : rs1 | | |||
| +-----------------+-------------------------+------------------------------------------------------------------------+ | |||
| | **cv.slet** | **rD, rs1, rs2** | rD = rs1 <= rs2 ? 1 : 0 | | |||
| | **cv.slet** | **rD, rs1, rs2** | rD[0] = rs1 <= rs2 ? 1 : 0 | | |||
There was a problem hiding this comment.
Hi @pascalgouedo , I do not agree that writing rd[0] is appropriate, it looks like the bits 31:1 are untouched, instead, they are set to 0, see the ALU result:
https://github.com/openhwgroup/cv32e40p/blob/master/rtl/cv32e40p_alu.sv#L973
I suggest we leave it as it was
| | | | Note: Comparison is signed | | ||
| +-----------------+-------------------------+------------------------------------------------------------------------+ | ||
| | **cv.sletu** | **rD, rs1, rs2** | rD = rs1 <= rs2 ? 1 : 0 | | ||
| | **cv.sletu** | **rD, rs1, rs2** | rD[0] = rs1 <= rs2 ? 1 : 0 | |
There was a problem hiding this comment.
Hi @davideschiavone
Yes you are right. I restore previous description for both SLET instructions.
Signed-off-by: Pascal Gouedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking into account some closed or not complete PR.