Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comb Loop #190

Closed
davideschiavone opened this issue Nov 5, 2019 · 4 comments
Closed

Comb Loop #190

davideschiavone opened this issue Nov 5, 2019 · 4 comments
Assignees
Labels
Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system

Comments

@davideschiavone
Copy link
Contributor

This functional fix:

f19f072

introduced a combinational loop in the prefetcher 32 bit version:

hwlp_masked --> fifo_i/in_valid_i --> fifo_i/out_valid_o --> hwlp_masked

Thanks @igorloi to find it!

@davideschiavone davideschiavone added the Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system label Nov 5, 2019
@davideschiavone davideschiavone self-assigned this Nov 5, 2019
davideschiavone added a commit that referenced this issue Nov 5, 2019
@davideschiavone
Copy link
Contributor Author

Please @igorloi , find here the tentative fix:

efba8a4

@igorloi
Copy link

igorloi commented Nov 5, 2019 via email

@yaronbe1
Copy link

fix looks ok
you can commit

@davideschiavone
Copy link
Contributor Author

Thanks @yaronbe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system
Projects
None yet
Development

No branches or pull requests

3 participants