Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to reply to issue #2403, #2407 and #2408 #2409

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

ludovicpion
Copy link
Contributor

To fix or provide changes related to #2403, #2407 and #2408

Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ludovicpion. I would like to request a few changes:

  1. There are separate copies of the LICENSE file for the pulse_gen and bp_gen components. These are not necessary since there is a top-level LICENSE file for this repository and there are license headers for all svh files.
  2. The bp_gen has an added layer of heirarchy (bp_gen/bp_gen) that does not seem to have any purpose.

@ludovicpion
Copy link
Contributor Author

Hi @MikeOpenHWGroup,

Regarding layer of heirarchy for the bp_gen, it is a mistake. I just fixed it.

For the LICENSE, all the cv_dv_utils have the same of managing it. I know that there is some redudancy but we agreed at the begining that it was ok to keep it like this. Is there any problem now?

Thanks,
Ludovic

@MikeOpenHWGroup
Copy link
Member

Thanks for fixing the "extra layer of hierarchy" issue. The redundant license files are unnecessary, but I am unaware of any legal reason not to included them, so I will approve/merge this PR.

Thanks for the contribution to CORE-V-VERIF!

@MikeOpenHWGroup MikeOpenHWGroup merged commit f7bda8e into openhwgroup:master Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants