Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore DSim #2397

Conversation

MikeOpenHWGroup
Copy link
Member

This PR re-establishes Metrics DSim as one of the SV simulators supported by CORE-V-VERIF. Changes fall into one of the following categories:

  • Fixes to Makefiles and associated scripts.
  • Workarounds for specific DSim parser issues. These are clearly identified in comments (look for "Metrics DSim") and do not alter the function or the code.
  • Increased the verbosity level for printing the testcase and environment configurations (from UVM_NONE to UVM_DEBUG).

Tested these changes with VCS, Questasim and DSim.

@MikeOpenHWGroup
Copy link
Member Author

Hi @XavierAubert, @YoannPruvost, @dd-baoshan and @dd-BeeNee, can one or more of you have a look at this? The DSim-specific scriptware will not affect you, but changes to cv32e40p/env/corev-dv/instr_lib/cv32e40p_float_instr_lib.sv, cv32e40p/env/uvme/cov/uvme_cv32e40p_cov_model.sv, cv32e40p/env/uvme/vseq/uvme_cv32e40p_random_debug_vseq.sv and cv32e40p/tb/uvmt/uvmt_cv32e40p_macros.sv might (I do not think so, but we should check).

I would also like your opinion on the change to verbosity for printing the testcase and environment configurations.

Copy link

@dd-baoshan dd-baoshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files changes are fine for me except uvmt_cv32e40p_base_test.sv.
I think it is fine to always print one time for test and env cfg during simulation. The performance impact is not huge and by it gives users a glace on the configurations whether for test/tb debugging or developing purpose.
Is there any concern that driven the changes of verbosity to UVM_DEBUG in base test?

@MikeOpenHWGroup
Copy link
Member Author

All files changes are fine for me except uvmt_cv32e40p_base_test.sv. ... Is there any concern that driven the changes of verbosity to UVM_DEBUG in base test?

You are right @dd-baoshan, that there is no performance impact of printing the test and testbench configurations to stdout, and it is a useful debug aid. Now that the environment is stable, this information is rarely used, so I increased the verbosity level for simply to reduce the amount of text printed to the screen. If you would prefer to keep it, that is fine, I will restore the printing of these configs.

@dd-baoshan
Copy link

dd-baoshan commented Apr 2, 2024

All files changes are fine for me except uvmt_cv32e40p_base_test.sv. ... Is there any concern that driven the changes of verbosity to UVM_DEBUG in base test?

You are right @dd-baoshan, that there is no performance impact of printing the test and testbench configurations to stdout, and it is a useful debug aid. Now that the environment is stable, this information is rarely used, so I increased the verbosity level for simply to reduce the amount of text printed to the screen. If you would prefer to keep it, that is fine, I will restore the printing of these configs.

It would be great to retain this print out because users can view the configuration details on development or debugging new tests that extend on this base test. I agreed that some configuration details are not really useful and also long because it uses the sprint function to ease the print out of all properties that recorded with objects util macro.

@MikeOpenHWGroup
Copy link
Member Author

It would be great to retain this print out

Done. I have pushed in an update to this PR that restores the original verbosity of the cfg dumps. Please have a look.

@dd-baoshan
Copy link

uvmt_cv32e40p_base_test.sv.

Thanks. btw, In my previous comment, the changes I trying to retain is on file uvmt_cv32e40p_base_test.sv because this file has already included the print out of test and env cfg. As for uvme_cv32e40p_env.sv, I am fine to made it UVM_DEBUG. As long as the tests are extended from base test, env cfg will be displayed. Since you have already reverted, I am fine as well.
AS conclusion, I am fine with all the changes you made.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 0042cbc into openhwgroup:cv32e40p/dev Apr 2, 2024
1 check passed
@MikeOpenHWGroup MikeOpenHWGroup deleted the cv32e40p/dev_restore_dsim branch April 2, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants