Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Vplan - Refresh JSON #2245

Merged

Conversation

silabs-robin
Copy link
Contributor

@silabs-robin silabs-robin commented Oct 16, 2023

This PR updates the debug vplan's json.

PR #2158 updated the debug vplan, before the younger json files PR #2193 was merged.
So I updated the debug vplan json with csv2json.
(I actually ran xlsx2csv on all vplans, then csv2json on all rerults, but debug was the only one who produced any changes.)

NB! No need to review thoroughly! The original PRs have already been reviewed.

Signed-off-by: Robin Pedersen <[email protected]>
Copy link

@silabs-krdosvik silabs-krdosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

(But as instructed, I have not looked through it very thoroughly.)

Considering that the vplan is already reviewed and that this PR simply change the format, I will approve.

@silabs-hfegran
Copy link
Contributor

@silabs-robin is this ready for a proper review? (It has been in draft stage for a little while)

@silabs-robin silabs-robin marked this pull request as ready for review October 24, 2023 07:07
Copy link
Contributor Author

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been in draft stage for a little while

I think maybe the "Create PR" button defaulted to draft because that's the laste mode I had used and I didn't notice.

@silabs-hfegran silabs-hfegran merged commit ccf12ea into openhwgroup:cv32e40s/dev Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants