-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccover s #2216
Ccover s #2216
Conversation
Signed-off-by: Kristine Dosvik <[email protected]>
…essary signal from assert Signed-off-by: Kristine Dosvik <[email protected]>
@@ -1,164 +1,197 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
<refinement-file-root> | |||
<information comment-version="1" creation-time="Fri 08 Sep 2023 16:33:54 CEST" creator="krdosvik" csCheck="true" modified-by="krdosvik" modify-time="Fri 22 Sep 2023 15:00:52 CEST" save-ref-method="seq" tool-version="Cadence vManager22.05" rules-signature-c="5ec06b80ed3aa56a354242dc7124e080"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hem, that I have changed this file was a bit unexpected. I will let it be a drafth PR to I have figured it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual_expression_cov_todo.vRefine seems to have changes that was also stored and modified (for the better) in the xsecure_trigger file.
.../tb/uvmt/uvmt_cv32e40s_xsecure_assert/uvmt_cv32e40s_xsecure_bus_protocol_hardening_assert.sv
Show resolved
Hide resolved
Signed-off-by: Kristine Dosvik <[email protected]>
…r_express_cov file Signed-off-by: Kristine Dosvik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on:
Expression coverage analysis is a nice addition.
Test status reported to be ok.
"Removed signal from assertions as it was not unnecessary" broadens the antecedent, so that should be a safe move.
Added vRefine file for some xsecure and trigger.
Removed signal from assertions as it was not unnecessary (assert property(!resp_ph_cont) passes).
Unglitched formal compiles,
Glitched formal passes.
The assertions are disabled in normal ci check, so have not tested it, but at least hello-world passes.