Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled buserr sb assertion due to false positives #2209

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Disabled buserr sb assertion due to false positives #2209

merged 1 commit into from
Sep 22, 2023

Conversation

silabs-hfegran
Copy link
Contributor

No description provided.

@silabs-hfegran
Copy link
Contributor Author

diff easier to read if you exclude whitespace changes

@silabs-hfegran
Copy link
Contributor Author

ci_check and formal OK

silabs-robin
silabs-robin approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on:
The regression problem this fixes is known, and this removes the problem.
The commented-out code has a todo, so it cannot be completely forgotten.
The code in question is not mission critical.

@silabs-robin silabs-robin merged commit 69d6096 into openhwgroup:cv32e40s/dev Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silabs-robin silabs-robin silabs-robin approved these changes

Assignees
No one assigned
Labels
cv32e40s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silabs-hfegran @silabs-robin