use correct csr privlevel path #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristine Dosvik <[email protected]>
silabs-krdosvik
requested review from
silabs-robin,
silabs-mateilga and
silabs-hfegran
|
Looks good, but we should probably delay merging until the mentioned bug is fixed. |
silabs-mateilga
approved these changes
Sep 13, 2023
|
Agreed! Now it is fixed! So would be nice to merge this asap |
|
This requires hash update of the S as well right? that's missing from this PR |
silabs-hfegran
requested changes
Sep 13, 2023
Signed-off-by: Kristine Dosvik <[email protected]>
silabs-hfegran
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTL has added an if statement that needs to be included in the path.
Formal compiles
Ci check is all red
But after this bug is fixed: openhwgroup/cv32e40s#499
It is all green except clic config tests (clic and debug_test2) (which I think is a clic problem and not something caused by this change, as that would be weird)