Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved clic assert fixmes for mscratchcsw and mscratchcswl #2166

Merged

Conversation

silabs-hfegran
Copy link
Contributor

@silabs-hfegran silabs-hfegran commented Aug 31, 2023

Fixme was in place to account for an rtl error that has since been resolved, the invalid csr instructions for mscratchcsw and mscratchcswl should now trap as expected, and the assertions have been updated accordingly

Copy link
Contributor

@silabs-mateilga silabs-mateilga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on:
Marton's CLIC-knowledge approval.
And, the assert looks stricter now.

@silabs-robin silabs-robin merged commit e9ef090 into openhwgroup:cv32e40s/dev Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants