add atomic to rvfi_instr_if, expand/divide the support pkg #2093
Conversation
Signed-off-by: Kristine Dosvik <[email protected]>
| `include "isa_tdefs.sv" | ||
| `include "isa_tdefs_csr.sv" | ||
| `include "isa_support.sv" //TODO: krdosvik, change name to isa_disassembler when no outstanding PR | ||
| `include "isa_functions.sv" |
There was a problem hiding this comment.
The includes in isa_functions.sv are also already included above this line.
There was a problem hiding this comment.
You mean isa_function is indirectly included by including the isa_support.sv? If that is what you mean: I didnt think about that, is that a problem? If not I think it is more readable to explicitly define what is meant to be included in the package, even though files might already include them.
There was a problem hiding this comment.
Regardless of the above, all these files needs compile-guards, otherwise there will be issues down the line.
There was a problem hiding this comment.
Beware of dangers like this:
If 1) an include file has guards, and 2) compilation of all source files is done as one "compilation unit", and 3) two other files include that include file, then C) only one of those other files will get any actual content from the include file.
|
I think this PR is a stale duplicate of another PR that got merged? If I'm wrong then please just re-open it. |
Added is_amo and is_atomic instr to rvfi_instr_if. Also restructured the isa_support. Will continue working on isa_support files when the merges from cv32e40s/dev to cv32e40x/dev, and cv32e40s to cv32e40x-dv is done.
Must wait to merge this PR untill openhwgroup/cv32e40x-dv#13 is merged, and we can update the clonetb hash.
Same status as openhwgroup/cv32e40x-dv#13 (ci check passes partially and formal compiles)