FPU test #1274
Merged
FPU test #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration files for PULP & FPU Added floating point test Signed-off-by: Pascal Gouedo <[email protected]>
MikeOpenHWGroup
requested changes
May 27, 2022
There was a problem hiding this comment.
Hi @pascalgouedo, I see that this PR is gated by cv32e40p pr707. I have pinged @davideschiavone to have a look at that. (As a general rule it is not a good idea for the verification people to approve updates to the RTL.) In the meantime, I have a few comments for this PR:
- Please add the appropriate license header to each of the new files. There are lots of examples in this repo you can copy-n-paste from. At a minimum you'll need:
# Copyright 2022 Dolphin Integration
# SPDX-License-Identifier: Apache-2.0 WITH SHL-2.1
-
Where did
stimuli.hfor test-programmatmul_32b_floatcome from? Maybe a comment or a README would be helpful. -
You will need to update the SHA (hash) for the CV32E40P RTL in cv32e40p/sim/ExternalRepos.mk after cv32e40p pr707 is completed.
added 5 commits
May 30, 2022 17:50
Added header and switched from tb cycle counter to core one Changed compiler options in yaml file Signed-off-by: Pascal Gouedo <[email protected]>
… (core + fpu wrapper and additional tb wrapper instantiating cv32e40p wrapper + logger and tracers) Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
…(can still be overidden at makeuvmt call) Signed-off-by: Pascal Gouedo <[email protected]>
Signed-off-by: Pascal Gouedo <[email protected]>
MikeOpenHWGroup
approved these changes
Jun 27, 2022
MikeOpenHWGroup
added a commit
that referenced
this pull request
Jun 27, 2022
|
Thanks @pascalgouedo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed cv32e40p wrapper instantiation (APU interface removal)
Added configuration files for PULP, CLUSTER & FPU
Added floating point test
!!! Depends on PR #1273 and cv32e40p PR openhwgroup/cv32e40p#707 !!!
Signed-off-by: Pascal Gouedo [email protected]