Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to core changes (addon.xml) #1798

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Adapt to core changes (addon.xml) #1798

merged 1 commit into from
Aug 23, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Aug 22, 2022

Depends on openhab/openhab-core#3050

Signed-off-by: Jan N. Klug [email protected]

@cdjackson
Copy link
Collaborator

I've not followed this change in core and I can't remember if this file is currently/previously used for anything more than as information to the UI, but can you confirm that this doesn't break anything - ie it doesn't require the latest core does it?

@J-N-K
Copy link
Member Author

J-N-K commented Aug 23, 2022

I believe as long as there is no configuration on binding level it'll work without binding.xml. But addon.xml is only required when the core PR has been merged, which depends on JDK17, so this is an issue for OH4, not the next release. At least binary compatibility will be lost then anyway because we'll upgrade to Karaf 4.4/OSGi R8. If maintaining source compatibility is required, we can leave binding.xml in place, it's just ignore by the new core.

@cdjackson
Copy link
Collaborator

That's fine - I don't think I'm too worried about backward compatibility in future - just that we don't break existing users of OH3.x stable who might want to use the newer binding for newer devices.

Thanks.

@cdjackson cdjackson merged commit dd1e7f9 into openhab:main Aug 23, 2022
cdjackson added a commit to cdjackson/org.openhab.binding.zwave that referenced this pull request Sep 17, 2022
cdjackson added a commit that referenced this pull request Sep 17, 2022
@J-N-K J-N-K deleted the addon_xml branch February 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants