Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Added Ecobee action bundle. #2755

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Added Ecobee action bundle. #2755

merged 1 commit into from
Aug 26, 2015

Conversation

watou
Copy link
Contributor

@watou watou commented Jun 18, 2015

The new bundle adds ten new actions for use with the Ecobee binding.

Parameters in italics are optional, in which case each unused parameter must be replaced with null. Read the API documentation to be sure you know the rules for calling these functions.

  • ecobeeAcknowledge(Item item, String thermostatIdentifier, String ackRef, String ackType, Boolean remindMeLater) - Acknowledge an alert.
  • ecobeeControlPlug(Item item, String plugName, String plugState, Date startDateTime, Date endDateTime, String holdType, Integer holdHours) - Control the on/off state of a plug by setting a hold on the plug.
  • ecobeeCreateVacation(Item item, String name, DecimalType coolHoldTemp, DecimalType heatHoldTemp, Date startDateTime, Date endDateTime, String fan, Integer fanMinOnTime) - Create a vacation event on the thermostat.
  • ecobeeDeleteVacation(Item item, String name) - Delete a vacation event from a thermostat.
  • ecobeeResetPreferences(Item item) - Set all user configurable settings back to the factory default values.
  • ecobeeResumeProgram(Item item, Boolean resumeAll) - Remove the currently running event providing the event is not a mandatory demand response event.
  • ecobeeSendMessage(Item item, String text) - Send an alert message to the thermostat.
  • ecobeeSetHold(Item item, DecimalType coolHoldTemp, DecimalType heatHoldTemp, String holdClimateRef, Date startDateTime, Date endDateTime, String holdType, Integer holdHours) - Set the thermostat into a hold with the specified temperature.
  • ecobeeSetOccupied(Item item, Boolean occupied, Date startDateTime, Date endDateTime, String holdType, Integer holdHours) - Switches a (EMS model only) thermostat from occupied mode to unoccupied, or vice versa.
  • ecobeeUpdateSensor(Item item, String name, String deviceId, String sensorId) - Update the name of an ecobee3 remote sensor.

@buildhive
Copy link

openHAB » openhab #3192 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@teichsta
Copy link
Member

Thanks @watou for this contribution! Hope to find the time for a review soon.

Can you confirm this Action is being shown in the Designer properly?

Best, Thomas E.-E.

@watou
Copy link
Contributor Author

watou commented Jun 18, 2015

Hi Thomas, even though your comment prompted me to add the missing entry to feature.xml, I still cannot see the new actions in the Designer (on macosx). There must still be something missing or incorrect in my PR. Can you offer any suggestions?

@buildhive
Copy link

openHAB » openhab #3199 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@watou
Copy link
Contributor Author

watou commented Jun 19, 2015

Added a note to issue #1403, which seems to be related to why the actions do not appear in the Designer.

@teichsta
Copy link
Member

Hi Thomas, even though your comment prompted me to add the missing entry to feature.xml

that was my intention ;-)

Also saw your comment on #1403 … i've also investigated some time already but didn't find an explanation. @kaikreuzer any additional ideas?

@buildhive
Copy link

openHAB » openhab #3208 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

openHAB » openhab #3215 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@watou
Copy link
Contributor Author

watou commented Jun 21, 2015

@teichsta, I'm thinking that I need to change the Integer parameter types in some of the actions to DecimalType before I test more, you review, etc. So I will comment here when I think this PR is suitable for your time. Thanks!

@buildhive
Copy link

openHAB » openhab #3239 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@teichsta
Copy link
Member

ok, than give me a sign, when you think this PR is ready for review. Thanks, Thomas E.-E.

@watou
Copy link
Contributor Author

watou commented Jun 28, 2015

@teichsta, this PR is ready for your review. Thank you!

@teichsta
Copy link
Member

ok, great, thanks!

@watou
Copy link
Contributor Author

watou commented Jun 29, 2015

Added testing discussion to the Google Group.

@watou
Copy link
Contributor Author

watou commented Jul 22, 2015

squashed and rebased off master

@watou
Copy link
Contributor Author

watou commented Jul 28, 2015

I will make changes that mirror those made in #2967 once it's merged, as well as rename the Java package org.openhab.binding.ecobee.internal.messages to org.openhab.binding.ecobee.messages. IMHO it would make the action bundle harder to use to require the user to specify the instance name and set of thermostats to target in the action call, since the user must already have a matching item binding, and all connection state is already maintained in the binding and is therefore dependent. Please let me know if this sounds acceptable in concept.

* mult-ecobees-1-acct-bug (PR openhab#2765)
* ecobee-celsius-arithmetic-exception (openhab#2793)
* ecobee-discard-tokens (PR openhab#2849)
* ecobee-echo-cancellation (PR openhab#2942)
* changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional.
* Quiesce logging when network failure keeps a poll from completing.
watou added a commit that referenced this pull request Aug 26, 2015
@watou watou merged commit d3129f1 into openhab:master Aug 26, 2015
@watou watou deleted the ecobee-action branch December 9, 2016 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants